Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2329133002: DevTools: do not run GYP actions on gclient sync. (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman-cc_chromium.org, mnaganov-cc_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

DevTools: do not run GYP actions on gclient sync. There's no need to run GYP actions since we've migrated to GN. BUG=none R=dgozman@chromium.org, dgozman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=d1cd0a724c995e8da4d98c2aca4096c930b438f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gce/uploader_iteration.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
lushnikov
please, take a look
4 years, 3 months ago (2016-09-10 00:33:44 UTC) #1
dgozman
lgtm
4 years, 3 months ago (2016-09-10 00:34:33 UTC) #2
lushnikov
4 years, 3 months ago (2016-09-10 00:41:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1cd0a724c995e8da4d98c2aca4096c930b438f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698