Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: Source/core/html/canvas/CanvasRenderingContext2D.cpp

Issue 232913004: Use StrictTypeChecking for methods on CRC2D that accepts Path2D (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update some more expectations. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/CanvasRenderingContext2D.cpp
diff --git a/Source/core/html/canvas/CanvasRenderingContext2D.cpp b/Source/core/html/canvas/CanvasRenderingContext2D.cpp
index a0807a878501ba7dbf78ad80b7d9f2cee8a31d97..5a64de5a4184a60f78cf12f8e77dc8d3ce6da035 100644
--- a/Source/core/html/canvas/CanvasRenderingContext2D.cpp
+++ b/Source/core/html/canvas/CanvasRenderingContext2D.cpp
@@ -1029,18 +1029,13 @@ void CanvasRenderingContext2D::fill(const String& windingRuleString)
fillInternal(m_path, windingRuleString);
}
-void CanvasRenderingContext2D::fill(Path2D* domPath, ExceptionState& exceptionState)
+void CanvasRenderingContext2D::fill(Path2D* domPath)
{
- fill(domPath, "nonzero", exceptionState);
+ fill(domPath, "nonzero");
}
-void CanvasRenderingContext2D::fill(Path2D* domPath, const String& windingRuleString, ExceptionState& exceptionState)
+void CanvasRenderingContext2D::fill(Path2D* domPath, const String& windingRuleString)
{
- if (!domPath) {
- exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(1, "Path"));
- return;
- }
-
fillInternal(domPath->path(), windingRuleString);
}
@@ -1077,13 +1072,8 @@ void CanvasRenderingContext2D::stroke()
strokeInternal(m_path);
}
-void CanvasRenderingContext2D::stroke(Path2D* domPath, ExceptionState& exceptionState)
+void CanvasRenderingContext2D::stroke(Path2D* domPath)
{
- if (!domPath) {
- exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(1, "Path"));
- return;
- }
-
strokeInternal(domPath->path());
}
@@ -1111,18 +1101,13 @@ void CanvasRenderingContext2D::clip(const String& windingRuleString)
clipInternal(m_path, windingRuleString);
}
-void CanvasRenderingContext2D::clip(Path2D* domPath, ExceptionState& exceptionState)
+void CanvasRenderingContext2D::clip(Path2D* domPath)
{
- clip(domPath, "nonzero", exceptionState);
+ clip(domPath, "nonzero");
}
-void CanvasRenderingContext2D::clip(Path2D* domPath, const String& windingRuleString, ExceptionState& exceptionState)
+void CanvasRenderingContext2D::clip(Path2D* domPath, const String& windingRuleString)
{
- if (!domPath) {
- exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(1, "Path"));
- return;
- }
-
clipInternal(domPath->path(), windingRuleString);
}
@@ -1131,18 +1116,13 @@ bool CanvasRenderingContext2D::isPointInPath(const float x, const float y, const
return isPointInPathInternal(m_path, x, y, windingRuleString);
}
-bool CanvasRenderingContext2D::isPointInPath(Path2D* domPath, const float x, const float y, ExceptionState& exceptionState)
+bool CanvasRenderingContext2D::isPointInPath(Path2D* domPath, const float x, const float y)
{
- return isPointInPath(domPath, x, y, "nonzero", exceptionState);
+ return isPointInPath(domPath, x, y, "nonzero");
}
-bool CanvasRenderingContext2D::isPointInPath(Path2D* domPath, const float x, const float y, const String& windingRuleString, ExceptionState& exceptionState)
+bool CanvasRenderingContext2D::isPointInPath(Path2D* domPath, const float x, const float y, const String& windingRuleString)
{
- if (!domPath) {
- exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(1, "Path"));
- return false;
- }
-
return isPointInPathInternal(domPath->path(), x, y, windingRuleString);
}
@@ -1172,13 +1152,8 @@ bool CanvasRenderingContext2D::isPointInStroke(const float x, const float y)
return isPointInStrokeInternal(m_path, x, y);
}
-bool CanvasRenderingContext2D::isPointInStroke(Path2D* domPath, const float x, const float y, ExceptionState& exceptionState)
+bool CanvasRenderingContext2D::isPointInStroke(Path2D* domPath, const float x, const float y)
{
- if (!domPath) {
- exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(1, "Path"));
- return false;
- }
-
return isPointInStrokeInternal(domPath->path(), x, y);
}
@@ -1210,13 +1185,8 @@ void CanvasRenderingContext2D::scrollPathIntoView()
scrollPathIntoViewInternal(m_path);
}
-void CanvasRenderingContext2D::scrollPathIntoView(Path2D* path2d, ExceptionState& exceptionState)
+void CanvasRenderingContext2D::scrollPathIntoView(Path2D* path2d)
{
- if (!path2d) {
- exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(1, "Path2D"));
- return;
- }
-
scrollPathIntoViewInternal(path2d->path());
}
« no previous file with comments | « Source/core/html/canvas/CanvasRenderingContext2D.h ('k') | Source/core/html/canvas/CanvasRenderingContext2D.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698