Use StrictTypeChecking for methods on CRC2D that accepts Path2D

LayoutTests/fast/canvas/canvas-isPointInPath-winding-expected.txt

Index: LayoutTests/fast/canvas/canvas-isPointInPath-winding-expected.txt
diff --git a/LayoutTests/fast/canvas/canvas-isPointInPath-winding-expected.txt b/LayoutTests/fast/canvas/canvas-isPointInPath-winding-expected.txt
index b77249fc406d74332c30b1a70f726037d667066e..72159a5932a9af637dcc588cdb67ddf7001c2fde 100644
--- a/LayoutTests/fast/canvas/canvas-isPointInPath-winding-expected.txt
+++ b/LayoutTests/fast/canvas/canvas-isPointInPath-winding-expected.txt
@@ -26,12 +26,12 @@ Testing evenodd isPointInPath with Path object
 PASS ctx.isPointInPath(path, 50, 50, 'evenodd') is false
 
 Testing null isPointInPath with Path object
-PASS ctx.isPointInPath(null, 50, 50) threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': The 1st argument provided is either null, or an invalid Path object..
-PASS ctx.isPointInPath(null, 50, 50, 'nonzero') threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': The 1st argument provided is either null, or an invalid Path object..
-PASS ctx.isPointInPath(null, 50, 50, 'evenodd') threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': The 1st argument provided is either null, or an invalid Path object..
-PASS ctx.isPointInPath(path, 50, 50) threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': The 1st argument provided is either null, or an invalid Path object..
-PASS ctx.isPointInPath(path, 50, 50, 'nonzero') threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': The 1st argument provided is either null, or an invalid Path object..
-PASS ctx.isPointInPath(path, 50, 50, 'evenodd') threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': The 1st argument provided is either null, or an invalid Path object..
+PASS ctx.isPointInPath(null, 50, 50) threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': parameter 3 ('50') is not a valid enum value..

[Justin Novosad, 2014/04/11 17:52:36]

This is the wrong error message.

[fs, 2014/04/11 18:31:19]

Well, it's not a great error message for sure... I believe this is due to the
overload handling (which needs some work) - essentially since the 'null' value
is not of type 'Path2D' the next overload is tried - <number, number, enum>. And
since the number 50 coerces into the string '50' you get this message. Thinking
about, I'm not even sure it'd work with better overload handling - a Path2D
object will never need conversion, and basically everything else can be turned
into 'float' (actually double - unrestricted). I'm not enough of a WebIDL expert
though.

[Nils Barth (inactive), 2014/04/14 02:32:18]

As Fredrik notes, this is actually the correct error message, due to Web IDL's
implicit conversion rules:
(null, 50, 50) matches (float, float, DOMString),
and thus is converted to
(0f, 50f, "50").
This then fails semantic validation once it is passed to the operation:
enumerations are resolved as strings, with checks happening afterwards.

The spec is as follows:
overload resolution algorithm:
http://heycam.github.io/webidl/#es-interface-call
(Narrowly speaking, the exact match is at step 11.)

...and then the TypeError is thrown in the enumeration handling:
http://heycam.github.io/webidl/#es-enumeration

So the Web IDL semantics are confusing (as they always are if you have
overloading and implicit conversion), but the code is an accurate reflection of
the reality.

An ideal solution for this case error message-wise would probably be to:
1. State which overload was matched.
2. State the raw inputs and converted values.
...though that's a bit involved.

+PASS ctx.isPointInPath(null, 50, 50, 'nonzero') threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': No function was found that matched the signature provided..

[Justin Novosad, 2014/04/11 17:52:36]

This error message is less informative than what we had before. I would consider
this to be a regression.

[fs, 2014/04/11 18:31:19]

Same issue as above, although here there's no additional overload to try so we
get the generic "No function matched" message.

[Nils Barth (inactive), 2014/04/14 02:32:18]

As Fredrik says: the new message is correct, the old message was wrong.
If you provide null for an argument and there's no function that has a nullable
parameter there, it simply shouldn't match.

It might be possible to give better error messages stating *which* argument
failed to match, but in general we can't say more than "didn't match", because
the overload resolution algorithm is very complicated.
Even in this case, we can't actually give a simple answer.
See, (null, 50) matches (Float, Float), converted to (0f, 50f),
so is the problem that you have a |null| instead of a Path,
or that you have (..., 50, 'nonzero')?

In simple cases we *may* be able to add some logic to give clearer error
messages, but this case is complex enough that we can't honestly give a clearer
answer.

+PASS ctx.isPointInPath(null, 50, 50, 'evenodd') threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': No function was found that matched the signature provided..
+PASS ctx.isPointInPath(path, 50, 50) threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': parameter 3 ('50') is not a valid enum value..
+PASS ctx.isPointInPath(path, 50, 50, 'nonzero') threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': No function was found that matched the signature provided..
+PASS ctx.isPointInPath(path, 50, 50, 'evenodd') threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': No function was found that matched the signature provided..
 
 Testing invalid type isPointInPath with Path object
 PASS ctx.isPointInPath([], 50, 50) threw exception TypeError: Failed to execute 'isPointInPath' on 'CanvasRenderingContext2D': parameter 3 ('50') is not a valid enum value..