samplecode/SampleUnpremul.cpp - Issue 232913003: Make sure SkDrawLooper objects can only be allocated on the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleUnpremul.cpp

Issue 232913003: Make sure SkDrawLooper objects can only be allocated on the heap. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samplecode/SampleUnpremul.cpp

diff --git a/samplecode/SampleUnpremul.cpp b/samplecode/SampleUnpremul.cpp

index f2f60cc3129e7c3798ba35ccd66f3bcb157fb644..0b1848df95d4e1606a14ada1aa988795e9bae30f 100644

--- a/samplecode/SampleUnpremul.cpp

+++ b/samplecode/SampleUnpremul.cpp

@@ -85,10 +85,10 @@ protected:

SkPaint paint;

paint.setAntiAlias(true);

paint.setTextSize(SkIntToScalar(24));

- SkAutoTUnref<SkBlurDrawLooper> looper(SkNEW_ARGS(SkBlurDrawLooper,

- (SK_ColorBLUE,

- SkBlurMask::ConvertRadiusToSigma(SkIntToScalar(2)),

- 0, 0)));

+ SkAutoTUnref<SkBlurDrawLooper> looper(

+ SkBlurDrawLooper::Create(SK_ColorBLUE,

+ SkBlurMask::ConvertRadiusToSigma(SkIntToScalar(2)),

+ 0, 0));

paint.setLooper(looper);

SkScalar height = paint.getFontMetrics(NULL);

if (!fDecodeSucceeded) {

« no previous file with comments | « samplecode/SampleTiling.cpp ('k') | src/effects/SkBlurDrawLooper.cpp » ('j') | no next file with comments »