Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: bench/BlurRoundRectBench.cpp

Issue 232913003: Make sure SkDrawLooper objects can only be allocated on the heap. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | bench/RectoriBench.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBenchmark.h" 8 #include "SkBenchmark.h"
9 #include "SkBlurMask.h" 9 #include "SkBlurMask.h"
10 #include "SkBlurMaskFilter.h" 10 #include "SkBlurMaskFilter.h"
(...skipping 22 matching lines...) Expand all
33 virtual const char* onGetName() SK_OVERRIDE { 33 virtual const char* onGetName() SK_OVERRIDE {
34 return fName.c_str(); 34 return fName.c_str();
35 } 35 }
36 36
37 virtual SkIPoint onGetSize() SK_OVERRIDE { 37 virtual SkIPoint onGetSize() SK_OVERRIDE {
38 return SkIPoint::Make(SkScalarCeilToInt(fRRect.rect().width()), 38 return SkIPoint::Make(SkScalarCeilToInt(fRRect.rect().width()),
39 SkScalarCeilToInt(fRRect.rect().height())); 39 SkScalarCeilToInt(fRRect.rect().height()));
40 } 40 }
41 41
42 virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE { 42 virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE {
43 SkLayerDrawLooper* looper = new SkLayerDrawLooper; 43 SkLayerDrawLooper::Builder looperBuilder;
44 { 44 {
45 SkLayerDrawLooper::LayerInfo info; 45 SkLayerDrawLooper::LayerInfo info;
46 info.fPaintBits = SkLayerDrawLooper::kMaskFilter_Bit 46 info.fPaintBits = SkLayerDrawLooper::kMaskFilter_Bit
47 | SkLayerDrawLooper::kColorFilter_Bit; 47 | SkLayerDrawLooper::kColorFilter_Bit;
48 info.fColorMode = SkXfermode::kSrc_Mode; 48 info.fColorMode = SkXfermode::kSrc_Mode;
49 info.fOffset = SkPoint::Make(SkIntToScalar(-1), SkIntToScalar(0)); 49 info.fOffset = SkPoint::Make(SkIntToScalar(-1), SkIntToScalar(0));
50 info.fPostTranslate = false; 50 info.fPostTranslate = false;
51 SkPaint* paint = looper->addLayerOnTop(info); 51 SkPaint* paint = looperBuilder.addLayerOnTop(info);
52 SkMaskFilter* maskFilter = SkBlurMaskFilter::Create( 52 SkMaskFilter* maskFilter = SkBlurMaskFilter::Create(
53 SkBlurMaskFilter::kNormal_BlurStyle, 53 SkBlurMaskFilter::kNormal_BlurStyle,
54 SkBlurMask::ConvertRadiusToSigma(SK_ScalarHalf), 54 SkBlurMask::ConvertRadiusToSigma(SK_ScalarHalf),
55 SkBlurMaskFilter::kHighQuality_BlurFlag); 55 SkBlurMaskFilter::kHighQuality_BlurFlag);
56 paint->setMaskFilter(maskFilter)->unref(); 56 paint->setMaskFilter(maskFilter)->unref();
57 SkColorFilter* colorFilter = SkColorFilter::CreateModeFilter(SK_Colo rLTGRAY, 57 SkColorFilter* colorFilter = SkColorFilter::CreateModeFilter(SK_Colo rLTGRAY,
58 SkXfermode::kSrcIn_Mode); 58 SkXfermode::kSrcIn_Mode);
59 paint->setColorFilter(colorFilter)->unref(); 59 paint->setColorFilter(colorFilter)->unref();
60 paint->setColor(SK_ColorGRAY); 60 paint->setColor(SK_ColorGRAY);
61 } 61 }
62 { 62 {
63 SkLayerDrawLooper::LayerInfo info; 63 SkLayerDrawLooper::LayerInfo info;
64 looper->addLayerOnTop(info); 64 looperBuilder.addLayerOnTop(info);
65 } 65 }
66 SkPaint dullPaint; 66 SkPaint dullPaint;
67 dullPaint.setAntiAlias(true); 67 dullPaint.setAntiAlias(true);
68 68
69 SkPaint loopedPaint; 69 SkPaint loopedPaint;
70 loopedPaint.setLooper(looper)->unref(); 70 loopedPaint.setLooper(looperBuilder.detachLooper())->unref();
71 loopedPaint.setAntiAlias(true); 71 loopedPaint.setAntiAlias(true);
72 loopedPaint.setColor(SK_ColorCYAN); 72 loopedPaint.setColor(SK_ColorCYAN);
73 73
74 for (int i = 0; i < loops; i++) { 74 for (int i = 0; i < loops; i++) {
75 canvas->drawRect(fRRect.rect(), dullPaint); 75 canvas->drawRect(fRRect.rect(), dullPaint);
76 canvas->drawRRect(fRRect, loopedPaint); 76 canvas->drawRRect(fRRect, loopedPaint);
77 } 77 }
78 } 78 }
79 79
80 private: 80 private:
81 SkString fName; 81 SkString fName;
82 SkRRect fRRect; 82 SkRRect fRRect;
83 83
84 typedef SkBenchmark INHERITED; 84 typedef SkBenchmark INHERITED;
85 }; 85 };
86 86
87 // Create one with dimensions/rounded corners based on the skp 87 // Create one with dimensions/rounded corners based on the skp
88 DEF_BENCH(return new BlurRoundRectBench(600, 5514, 6);) 88 DEF_BENCH(return new BlurRoundRectBench(600, 5514, 6);)
89 // Same radii, much smaller rectangle 89 // Same radii, much smaller rectangle
90 DEF_BENCH(return new BlurRoundRectBench(100, 100, 6);) 90 DEF_BENCH(return new BlurRoundRectBench(100, 100, 6);)
91 // Other radii options 91 // Other radii options
92 DEF_BENCH(return new BlurRoundRectBench(100, 100, 30);) 92 DEF_BENCH(return new BlurRoundRectBench(100, 100, 30);)
93 DEF_BENCH(return new BlurRoundRectBench(100, 100, 90);) 93 DEF_BENCH(return new BlurRoundRectBench(100, 100, 90);)
OLDNEW
« no previous file with comments | « no previous file | bench/RectoriBench.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698