Issue 232913002: Treat uninitialized as internal type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232913002: Treat uninitialized as internal type. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Treat uninitialized as internal type. TEST=cctest/test-types R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20650

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	src/types.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/cctest/test-types.cc	View		4 chunks	+17 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

lgtm https://codereview.chromium.org/232913002/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (right): https://codereview.chromium.org/232913002/diff/1/test/cctest/test-types.cc#newcode561 test/cctest/test-types.cc:561: CheckSub(T.UninitializedClass, T.Internal); Nit: these should go to the ...

6 years, 8 months ago (2014-04-10 11:39:44 UTC) #2

Benedikt Meurer

6 years, 8 months ago (2014-04-10 11:51:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20650 (presubmit successful).

Expand Messages | Collapse Messages