Issue 23291003: Don't try to use compositor to display dialog before compositor is initialized

Issue 23291003: Don't try to use compositor to display dialog before compositor is initialized (Closed)

Created:
7 years, 4 months ago by scottmg

Modified:
7 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't try to use compositor to display dialog before compositor is initialized R=sky@chromium.org BUG=273910 TEST=on XM VM, set compatibility mode to "Windows 98 / Windows Me" and make sure the dialog is displayed Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218428

Patch Set 1 #

Patch Set 2 : check ContextFactory instead of Compositor since that's actually what's needed #

Total comments: 1

Patch Set 3 : refactor to avoid copying #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -10 lines)			Patch
M	chrome/browser/ui/views/simple_message_box_views.cc	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/simple_message_box_win.h	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/simple_message_box_win.cc	View	1 2	2 chunks	+18 lines, -9 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

sky

https://codereview.chromium.org/23291003/diff/3001/chrome/browser/ui/views/simple_message_box_views.cc File chrome/browser/ui/views/simple_message_box_views.cc (right): https://codereview.chromium.org/23291003/diff/3001/chrome/browser/ui/views/simple_message_box_views.cc#newcode180 chrome/browser/ui/views/simple_message_box_views.cc:180: #if defined(USE_AURA) && defined(OS_WIN) Can you refactor simple_message_box_win.cc so ...

7 years, 4 months ago (2013-08-19 16:56:12 UTC) #2

scottmg

On 2013/08/19 16:56:12, sky wrote: > https://codereview.chromium.org/23291003/diff/3001/chrome/browser/ui/views/simple_message_box_views.cc > File chrome/browser/ui/views/simple_message_box_views.cc (right): > > https://codereview.chromium.org/23291003/diff/3001/chrome/browser/ui/views/simple_message_box_views.cc#newcode180 > ...

7 years, 4 months ago (2013-08-19 16:57:28 UTC) #3

sky

Yes please. On Mon, Aug 19, 2013 at 9:57 AM, <scottmg@chromium.org> wrote: > On 2013/08/19 ...

7 years, 4 months ago (2013-08-19 17:00:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23291003/10001

7 years, 4 months ago (2013-08-20 00:10:08 UTC) #7

Message was sent while issue was closed.

Change committed as 218428

Expand Messages | Collapse Messages