Complete migration to InspectorFrontendHost.sendMessageToFrontendHost.

Source/core/inspector/InspectorFrontendHost.cpp

 /*
  * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 118 matching lines @@
     m_client = 0;
     if (m_menuProvider)
         m_menuProvider->disconnect();
     m_frontendPage = 0;
 }
 
 void InspectorFrontendHost::loaded()
 {
 }
 
-void InspectorFrontendHost::requestSetDockSide(const String& side)
-{
-    if (!m_client)
-        return;
-    if (side == "undocked")
-        m_client->requestSetDockSide(InspectorFrontendClient::Undocked);

[pfeldman, 2013/08/23 11:34:15]

Remove these constants as well.

[Vladislav Kaznacheev, 2013/08/30 14:37:00]

Done.

-    else if (side == "right")
-        m_client->requestSetDockSide(InspectorFrontendClient::DockedToRight);
-    else if (side == "bottom")
-        m_client->requestSetDockSide(InspectorFrontendClient::DockedToBottom);
-}
-
-void InspectorFrontendHost::closeWindow()
-{
-    if (m_client) {
-        m_client->closeWindow();
-        disconnectClient(); // Disconnect from client.

[pfeldman, 2013/08/23 11:34:15]

This was also clearing m_client. Leave it as is and emit "closeWindow" from
here.

[Vladislav Kaznacheev, 2013/08/30 14:37:00]

Done in the previous patch, already committed
(https://chromiumcodereview.appspot.com/23289002/)

On 2013/08/23 11:34:15, pfeldman wrote:

-    }
-}
-
-void InspectorFrontendHost::bringToFront()
-{
-    if (m_client)
-        m_client->bringToFront();
-}
-
 void InspectorFrontendHost::setZoomFactor(float zoom)
 {
     m_frontendPage->mainFrame()->setPageAndTextZoomFactors(zoom, 1);
 }
 
 void InspectorFrontendHost::inspectedURLChanged(const String& newURL)
 {
     if (m_client)
         m_client->inspectedURLChanged(newURL);
 }
 
-void InspectorFrontendHost::setAttachedWindowHeight(unsigned height)
-{
-    if (m_client)
-        m_client->changeAttachedWindowHeight(height);
-}
-
-void InspectorFrontendHost::moveWindowBy(float x, float y) const
-{
-    if (m_client)
-        m_client->moveWindowBy(x, y);
-}
-
 void InspectorFrontendHost::setInjectedScriptForOrigin(const String& origin, const String& script)
 {
     m_frontendPage->inspectorController().setInjectedScriptForOrigin(origin, script);
 }
 
 String InspectorFrontendHost::localizedStringsURL()
 {
     return "";
 }
 
 void InspectorFrontendHost::copyText(const String& text)
 {
     Pasteboard::generalPasteboard()->writePlainText(text, Pasteboard::CannotSmartReplace);
 }
 
-void InspectorFrontendHost::openInNewTab(const String& url)
-{
-    if (m_client)
-        m_client->openInNewTab(url);
-}
-
 bool InspectorFrontendHost::canSave()
 {
     return true;
 }
 
-void InspectorFrontendHost::save(const String& url, const String& content, bool forceSaveAs)
-{
-    if (m_client)
-        m_client->save(url, content, forceSaveAs);
-}
-
-void InspectorFrontendHost::append(const String& url, const String& content)
-{
-    if (m_client)
-        m_client->append(url, content);
-}
-
 void InspectorFrontendHost::close(const String&)
 {
 }
 
 void InspectorFrontendHost::sendMessageToBackend(const String& message)
 {
     if (m_client)
         m_client->sendMessageToBackend(message);
 }
 
@@ skipping 49 matching lines @@
 {
     Color color = m_frontendPage->theme()->activeSelectionForegroundColor();
     return color != Color::transparent ? color.serialized() : "";
 }
 
 bool InspectorFrontendHost::supportsFileSystems()
 {
     return true;
 }
 
-void InspectorFrontendHost::requestFileSystems()
-{
-    if (m_client)
-        m_client->requestFileSystems();
-}
-
-void InspectorFrontendHost::addFileSystem()
-{
-    if (m_client)
-        m_client->addFileSystem();
-}
-
-void InspectorFrontendHost::removeFileSystem(const String& fileSystemPath)
-{
-    if (m_client)
-        m_client->removeFileSystem(fileSystemPath);
-}
-
 PassRefPtr<DOMFileSystem> InspectorFrontendHost::isolatedFileSystem(const String& fileSystemName, const String& rootURL)
 {
     ScriptExecutionContext* context = m_frontendPage->mainFrame()->document();
     return DOMFileSystem::create(context, fileSystemName, FileSystemTypeIsolated, KURL(ParsedURLString, rootURL), AsyncFileSystem::create());
 }
 
-void InspectorFrontendHost::indexPath(int requestId, const String& fileSystemPath)
-{
-    if (m_client)
-        m_client->indexPath(requestId, fileSystemPath);
-}
-
-void InspectorFrontendHost::stopIndexing(int requestId)
-{
-    if (m_client)
-        m_client->stopIndexing(requestId);
-}
-
-void InspectorFrontendHost::searchInPath(int requestId, const String& fileSystemPath, const String& query)
-{
-    if (m_client)
-        m_client->searchInPath(requestId, fileSystemPath, query);
-}
-
 bool InspectorFrontendHost::isUnderTest()
 {
     return m_client && m_client->isUnderTest();
 }
 
 bool InspectorFrontendHost::canSaveAs()
 {
     return false;
 }
 
 bool InspectorFrontendHost::canInspectWorkers()
 {
     return false;
 }
 
 String InspectorFrontendHost::hiddenPanels()
 {
     return "";
 }
 
 } // namespace WebCore