[omnibox] Return reference to ImageView instead of LocationIconView

[omnibox] Return reference to ImageView instead of LocationIconView

Return a reference to the contained ImageView (the padlock) instead of
the parent LocationIconView. The latter is quite wide when we fill in
the label half of it, which we now do with site security level in some
cases. The bubble (in the bug that is in the wrong place)  anchors to
the middle of whatever View you return to it, so we really want to
give it the padlock here.

BUG=644222
Committed: https://crrev.com/17cb9a2ce95bfaf85f4b209c45e87aa3da117326
Cr-Commit-Position: refs/heads/master@{#417932}

[Kevin Bailey, 2016-09-09 18:27:17]

Description was changed from

==========
[omnibox] Return reference to ImageView instead of LocationIconView

Return a reference to the contained ImageView (the padlock) instead of
the parent LocationIconView. The latter is quite wide when we fill in
the label half of it, which we now do with site security level in some
cases. The bubble (in the bug that is in the wrong place)  anchors to
the middle of whatever View you return to it, so we really want to
give it the padlock here.

BUG=644222
==========

to

==========
[omnibox] Return reference to ImageView instead of LocationIconView

Return a reference to the contained ImageView (the padlock) instead of
the parent LocationIconView. The latter is quite wide when we fill in
the label half of it, which we now do with site security level in some
cases. The bubble (in the bug that is in the wrong place)  anchors to
the middle of whatever View you return to it, so we really want to
give it the padlock here.

BUG=644222
==========

[Kevin Bailey, 2016-09-09 18:27:17]

krb@chromium.org changed reviewers:
+ hcarmona@chromium.org

[Kevin Bailey, 2016-09-09 18:28:31]

On 2016/09/09 18:27:17, Kevin Bailey wrote:
> mailto:krb@chromium.org changed reviewers:
> + mailto:hcarmona@chromium.org

Hi Hector,

Before sending off for owner review, does it look ok to you?

thx

[Kevin Bailey, 2016-09-09 20:54:49]

krb@chromium.org changed reviewers:
+ benwells@chromium.org
- hcarmona@chromium.org

[Kevin Bailey, 2016-09-09 20:56:44]

On 2016/09/09 18:28:31, Kevin Bailey wrote:
> On 2016/09/09 18:27:17, Kevin Bailey wrote:
> > mailto:krb@chromium.org changed reviewers:
> > + mailto:hcarmona@chromium.org
> 
> Hi Hector,
> 
> Before sending off for owner review, does it look ok to you?
> 
> thx

Hector and I chatted and tested it out locally.

Ben, could you take an owner's look ?

thx!

[benwells, 2016-09-12 03:24:51]

lgtm

[Kevin Bailey, 2016-09-12 13:19:18]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 13:19:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 13:55:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 13:55:38]

Dry run: This issue passed the CQ dry run.

[Kevin Bailey, 2016-09-12 13:57:45]

The CQ bit was checked by krb@chromium.org

[commit-bot: I haz the power, 2016-09-12 13:57:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 14:01:26]

Description was changed from

==========
[omnibox] Return reference to ImageView instead of LocationIconView

Return a reference to the contained ImageView (the padlock) instead of
the parent LocationIconView. The latter is quite wide when we fill in
the label half of it, which we now do with site security level in some
cases. The bubble (in the bug that is in the wrong place)  anchors to
the middle of whatever View you return to it, so we really want to
give it the padlock here.

BUG=644222
==========

to

==========
[omnibox] Return reference to ImageView instead of LocationIconView

Return a reference to the contained ImageView (the padlock) instead of
the parent LocationIconView. The latter is quite wide when we fill in
the label half of it, which we now do with site security level in some
cases. The bubble (in the bug that is in the wrong place)  anchors to
the middle of whatever View you return to it, so we really want to
give it the padlock here.

BUG=644222
==========

[commit-bot: I haz the power, 2016-09-12 14:01:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-12 14:04:19]

Description was changed from

==========
[omnibox] Return reference to ImageView instead of LocationIconView

Return a reference to the contained ImageView (the padlock) instead of
the parent LocationIconView. The latter is quite wide when we fill in
the label half of it, which we now do with site security level in some
cases. The bubble (in the bug that is in the wrong place)  anchors to
the middle of whatever View you return to it, so we really want to
give it the padlock here.

BUG=644222
==========

to

==========
[omnibox] Return reference to ImageView instead of LocationIconView

Return a reference to the contained ImageView (the padlock) instead of
the parent LocationIconView. The latter is quite wide when we fill in
the label half of it, which we now do with site security level in some
cases. The bubble (in the bug that is in the wrong place)  anchors to
the middle of whatever View you return to it, so we really want to
give it the padlock here.

BUG=644222

Committed: https://crrev.com/17cb9a2ce95bfaf85f4b209c45e87aa3da117326
Cr-Commit-Position: refs/heads/master@{#417932}
==========

[commit-bot: I haz the power, 2016-09-12 14:04:21]

Patchset 1 (id:??) landed as
https://crrev.com/17cb9a2ce95bfaf85f4b209c45e87aa3da117326
Cr-Commit-Position: refs/heads/master@{#417932}