Adds a delete button to chrome:offline-internals

chrome/browser/resources/offline_pages/offline_internals.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('offlineInternals', function() {
   'use strict';
 
   /** @type {!Array<OfflinePage>} */
   var offlinePages = [];
 
@@ skipping 54 matching lines @@
    * @param {!Array<SavePageRequest>} requests An array object representing
    *     the request queue.
    */
   function fillRequestQueue(requests) {
     var requestQueueTable = $('request-queue');
     requestQueueTable.textContent = '';
 
     for (var i = 0; i < requests.length; i++) {
       var row = document.createElement('tr');
 
+      var checkboxCell = document.createElement('td');
+      var checkbox = document.createElement('input');
+      checkbox.setAttribute('type', 'checkbox');
+      checkbox.setAttribute('name', 'requests');
+      checkbox.setAttribute('value', requests[i].id);
+
+      checkboxCell.appendChild(checkbox);
+      row.appendChild(checkboxCell);
+
       var cell = document.createElement('td');
       cell.textContent = requests[i].onlineUrl;
       row.appendChild(cell);
 
       cell = document.createElement('td');
       cell.textContent = new Date(requests[i].creationTime);
       row.appendChild(cell);
 
       cell = document.createElement('td');
       cell.textContent = requests[i].status;
@@ skipping 31 matching lines @@
   }
 
   /**
    * Delete all pages in the offline store.
    */
   function deleteAllPages() {
     browserProxy_.deleteAllPages().then(pagesDeleted);
   }
 
   /**
+   * Delete all pending SavePageRequest items in the request queue.
+   */
+  function deleteAllRequests() {
+    browserProxy_.deleteAllRequests().then(requestsDeleted);
+  }
+
+  /**
    * Callback when pages are deleted.
    * @param {string} status The status of the request.
    */
   function pagesDeleted(status) {
     $('page-actions-info').textContent = status;
     browserProxy_.getStoredPages().then(fillStoredPages);
   }
 
   /**
+   * Callback when requests are deleted.
+   */
+  function requestsDeleted(status) {
+    $('page-actions-info').textContent = status;

[chili, 2016/09/12 20:26:01]

page-actions-info is a div between the stored pages table and request queue
table.  Should we have another info? (i.e. have stored-pages-actions-info and
request-queue-actions-info)?

[Pete Williamson, 2016/09/12 22:46:35]

Done.

+    browserProxy_.getRequestQueue().then(fillRequestQueue);
+  }
+
+  /**
    * Downloads all the stored page and request queue information into a file.
    * TODO(chili): Create a CSV writer that can abstract out the line joining.
    */
   function download() {
     var json = JSON.stringify({
       offlinePages: offlinePages,
       savePageRequests: savePageRequests
     }, null, 2);
 
     window.open(
@@ skipping 19 matching lines @@
 
     for (var i = 0; i < checkboxes.length; i++) {
       if (checkboxes[i].checked)
         selectedIds.push(checkboxes[i].value);
     }
 
     browserProxy_.deleteSelectedPages(selectedIds).then(pagesDeleted);
   }
 
   /**
+   * Delete selected SavePageRequest items from the request queue.
+   */
+  function deleteSelectedRequests() {
+    var checkboxes = document.getElementsByName('requests');
+    var selectedIds = [];
+
+    for (var i = 0; i < checkboxes.length; i++) {
+      if (checkboxes[i].checked)
+        selectedIds.push(checkboxes[i].value);
+    }
+
+    browserProxy_.deleteSelectedRequests(selectedIds).then(requestsDeleted);
+  }
+
+  /**
    * Refreshes the logs.
    */
   function refreshLog() {
     browserProxy_.getEventLogs().then(fillEventLog);
     browserProxy_.getLoggingState().then(updateLogStatus);
   }
 
   function initialize() {
     /**
      * @param {!boolean} enabled Whether to enable Logging.
      */
     function togglePageModelLog(enabled) {
       browserProxy_.setRecordPageModel(enabled);
       $('model-status').textContent = enabled ? 'On' : 'Off';
     }
 
     /**
      * @param {!boolean} enabled Whether to enable Logging.
      */
     function toggleRequestQueueLog(enabled) {
       browserProxy_.setRecordRequestQueue(enabled);
       $('request-status').textContent = enabled ? 'On' : 'Off';
     }
 
     var incognito = loadTimeData.getBoolean('isIncognito');
     $('clear-all').disabled = incognito;
     $('clear-selected').disabled = incognito;
+    $('delete-all').disabled = incognito;
+    $('delete-selected').disabled = incognito;
     $('log-model-on').disabled = incognito;
     $('log-model-off').disabled = incognito;
     $('log-request-on').disabled = incognito;
     $('log-request-off').disabled = incognito;
     $('refresh').disabled = incognito;
 
     $('clear-all').onclick = deleteAllPages;
     $('clear-selected').onclick = deleteSelectedPages;
+    $('delete-all').onclick = deleteAllRequests;
+    $('delete-selected').onclick = deleteSelectedRequests;
     $('refresh').onclick = refreshAll;
     $('download').onclick = download;
     $('log-model-on').onclick = togglePageModelLog.bind(this, true);
     $('log-model-off').onclick = togglePageModelLog.bind(this, false);
     $('log-request-on').onclick = toggleRequestQueueLog.bind(this, true);
     $('log-request-off').onclick = toggleRequestQueueLog.bind(this, false);
     $('refresh-logs').onclick = refreshLog;
     $('add-to-queue').onclick = function() {
       var saveUrls = $('url').value.split(',');
       var counter = saveUrls.length;
@@ skipping 20 matching lines @@
       refreshAll();
   }
 
   // Return an object with all of the exports.
   return {
     initialize: initialize,
   };
 });
 
 document.addEventListener('DOMContentLoaded', offlineInternals.initialize);