Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2328923002: Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in Editor::replaceSelectionWithFragme… (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent, keishi, yosin_UTC9
CC:
blink-reviews, chromium-reviews, dtapuska+blinkwatch_chromium.org, groby+blinkspell_chromium.org, kinuko+watch, nzolghadr+blinkwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in Editor::replaceSelectionWithFragment BUG=590369 Committed: https://crrev.com/dad565a636702bd5227f3683bf48b2ef73c18b26 Cr-Commit-Position: refs/heads/master@{#417878}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-09 09:57:34 UTC) #4
yosin_UTC9
https://codereview.chromium.org/2328923002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/2328923002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode2470 third_party/WebKit/Source/core/input/EventHandler.cpp:2470: m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets(); We should do updateStyleXXX in Editor::handleTextEvnet() rather than ...
4 years, 3 months ago (2016-09-12 04:06:00 UTC) #7
Xiaocheng
Updated. PTAL. https://codereview.chromium.org/2328923002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/2328923002/diff/1/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode2470 third_party/WebKit/Source/core/input/EventHandler.cpp:2470: m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets(); On 2016/09/12 at 04:06:00, Yosi_UTC9 wrote: ...
4 years, 3 months ago (2016-09-12 04:48:27 UTC) #10
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-12 04:53:15 UTC) #11
Xiaocheng
+keishi@ since tkent@ is OOO today. keishi: Could you take a look? Thanks!
4 years, 3 months ago (2016-09-12 05:45:34 UTC) #13
keishi
LGTM
4 years, 3 months ago (2016-09-12 05:47:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328923002/20001
4 years, 3 months ago (2016-09-12 06:10:21 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 06:14:02 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 06:15:51 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dad565a636702bd5227f3683bf48b2ef73c18b26
Cr-Commit-Position: refs/heads/master@{#417878}

Powered by Google App Engine
This is Rietveld 408576698