Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in Editor::replaceSelectionWithFragme…

Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in Editor::replaceSelectionWithFragment

BUG=590369
Committed: https://crrev.com/dad565a636702bd5227f3683bf48b2ef73c18b26
Cr-Commit-Position: refs/heads/master@{#417878}

[Xiaocheng, 2016-09-09 08:50:46]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 08:51:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-09 09:57:34]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-09-09 09:57:34]

PTAL.

[commit-bot: I haz the power, 2016-09-09 10:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 10:18:30]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-09-12 04:06:00]

https://codereview.chromium.org/2328923002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2328923002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:2470:
m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
We should do updateStyleXXX in Editor::handleTextEvnet() rather than here.
It is hard to image why handleTextEvent requires clean layout tree.
It is implementation details of handleTextEvent()

[Xiaocheng, 2016-09-12 04:29:21]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 04:29:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-12 04:48:27]

Updated. PTAL.

https://codereview.chromium.org/2328923002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2328923002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:2470:
m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/09/12 at 04:06:00, Yosi_UTC9 wrote:
> We should do updateStyleXXX in Editor::handleTextEvnet() rather than here.
> It is hard to image why handleTextEvent requires clean layout tree.
> It is implementation details of handleTextEvent()

Reasonable. Done.

[yosin_UTC9, 2016-09-12 04:53:15]

lgtm

[Xiaocheng, 2016-09-12 05:45:34]

xiaochengh@chromium.org changed reviewers:
+ keishi@chromium.org

[Xiaocheng, 2016-09-12 05:45:34]

+keishi@ since tkent@ is OOO today.

keishi: Could you take a look? Thanks!

[keishi, 2016-09-12 05:47:05]

LGTM

[commit-bot: I haz the power, 2016-09-12 06:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 06:08:10]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-12 06:10:05]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-09-12 06:10:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 06:14:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 06:15:50]

Description was changed from

==========
Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in
Editor::replaceSelectionWithFragment

BUG=590369
==========

to

==========
Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in
Editor::replaceSelectionWithFragment

BUG=590369

Committed: https://crrev.com/dad565a636702bd5227f3683bf48b2ef73c18b26
Cr-Commit-Position: refs/heads/master@{#417878}
==========

[commit-bot: I haz the power, 2016-09-12 06:15:51]

Patchset 2 (id:??) landed as
https://crrev.com/dad565a636702bd5227f3683bf48b2ef73c18b26
Cr-Commit-Position: refs/heads/master@{#417878}