Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2328903002: [Reland] cheets: implement cros side of WallpaperManager API. (Closed)

Created:
4 years, 3 months ago by Muyuan
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, oshima+watch_chromium.org, darin (slow to review), davemoore+watch_chromium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] cheets: implement cros side of WallpaperManager API. This reverts "Revert of cheets: implement cros side of WallpaperManagerService." commit 9aea000394714d2fbb20850021f6204f2256b9cf. This fixes build for (patchset 16 id:300001 of https://codereview.chromium.org/2264743002/ ) which was broken due to commit queue conflict. TBR=xiaohuic@chromium.org,xiyuan@chromium.org,nya@chromium.org,lhchavez@chromium.org,hidehiko@chromium.org,dcheng@chromium.org,yusukes@chromium.org,muyuanli@chromium.org BUG=642465 Committed: https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7 Cr-Commit-Position: refs/heads/master@{#417618}

Patch Set 1 #

Patch Set 2 : Fixed build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -149 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_service_launcher.cc View 3 chunks +3 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_wallpaper_handler.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_wallpaper_handler.cc View 1 chunk +0 lines, -89 lines 0 comments Download
A chrome/browser/chromeos/arc/arc_wallpaper_service.h View 1 chunk +59 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/arc/arc_wallpaper_service.cc View 1 3 chunks +56 lines, -6 lines 0 comments Download
M components/arc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/arc_bridge_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/arc/arc_bridge_host_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/arc/arc_bridge_service.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 2 chunks +6 lines, -2 lines 0 comments Download
A components/arc/common/wallpaper.mojom View 1 chunk +25 lines, -0 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M components/arc/set_wallpaper_delegate.h View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Luis Héctor Chávez
lgtm thanks for doing it again with a simpler diff :)
4 years, 3 months ago (2016-09-09 15:24:13 UTC) #1
xiyuan
lgtm
4 years, 3 months ago (2016-09-09 16:47:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328903002/20001
4 years, 3 months ago (2016-09-09 17:34:40 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 17:39:06 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 17:41:08 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bf98813246a297671602f6aaf435a9c0a43141a7
Cr-Commit-Position: refs/heads/master@{#417618}

Powered by Google App Engine
This is Rietveld 408576698