Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2328893002: Add FPDF_ANNOT in PDFiumEngine::GetRenderingFlags. (Closed)

Created:
4 years, 3 months ago by jaepark
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FPDF_ANNOT in PDFiumEngine::GetRenderingFlags. This is a preparation CL for implementing toggle annotation button. FPDF_ANNOT flag is needed to draw non-widget type PDF annotations, such as text, highlight, underline, etc. Same flag needs to be passed to FPDF_RenderPageBitmap_Start and FPDF_FFLDraw in order to display / hide popup window associated to non-widget annotation on mouse-hover. BUG=642982 Committed: https://crrev.com/a9b2754f28b5f29378a348f05ba27abbb1853f03 Cr-Commit-Position: refs/heads/master@{#417745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pdf/pdfium/pdfium_engine.h View 1 chunk +3 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jaepark
https://codereview.chromium.org/2323203002 should be resolved before landing this patch.
4 years, 3 months ago (2016-09-09 02:53:43 UTC) #2
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-09 22:22:56 UTC) #7
jaepark
On 2016/09/09 22:22:56, Lei Zhang wrote: > lgtm https://codereview.chromium.org/2323203002/ is resolved.
4 years, 3 months ago (2016-09-09 22:42:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328893002/1
4 years, 3 months ago (2016-09-09 22:43:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 22:48:59 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 22:51:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9b2754f28b5f29378a348f05ba27abbb1853f03
Cr-Commit-Position: refs/heads/master@{#417745}

Powered by Google App Engine
This is Rietveld 408576698