Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2328883002: Remove unused PATCH_TOOL and resulting dead code from bot_update. (Closed)

Created:
4 years, 3 months ago by iannucci
Modified:
4 years, 3 months ago
Reviewers:
agable, estaab, martiniss, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix "test" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -94 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 8 chunks +8 lines, -92 lines 0 comments Download
M tests/bot_update_coverage_test.py View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
iannucci
4 years, 3 months ago (2016-09-09 01:10:03 UTC) #1
agable
lgtm
4 years, 3 months ago (2016-09-09 01:11:39 UTC) #2
iannucci
https://chromiumcodereview.appspot.com/2328883002/diff/1/recipe_modules/bot_update/resources/bot_update.py File recipe_modules/bot_update/resources/bot_update.py (left): https://chromiumcodereview.appspot.com/2328883002/diff/1/recipe_modules/bot_update/resources/bot_update.py#oldcode788 recipe_modules/bot_update/resources/bot_update.py:788: refs, git_cache_dir, gerrit_reset): gyp_env and runhooks were leftovers from ...
4 years, 3 months ago (2016-09-09 01:11:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328883002/1
4 years, 3 months ago (2016-09-09 01:13:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3125537bf8bf4310)
4 years, 3 months ago (2016-09-09 01:19:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328883002/20001
4 years, 3 months ago (2016-09-09 01:24:55 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 01:27:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/3dd7436899f87b...

Powered by Google App Engine
This is Rietveld 408576698