Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2328873004: mojom GNI: Implicit variant inheritance for deps (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojom GNI: Implicit variant inheritance for deps If a mojom target foo depends on mojom target bar, we want the "foo_blink" target to depend on "bar_blink" implicitly. This makes that happen. BUG=645660 R=yzshen@chromium.org Committed: https://crrev.com/a803c034985e873747aebb91769258a7842cac69 Cr-Commit-Position: refs/heads/master@{#417782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M mojo/public/tools/bindings/mojom.gni View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Ken Rockot(use gerrit already)
4 years, 3 months ago (2016-09-09 22:25:37 UTC) #2
Ken Rockot(use gerrit already)
BTW for a useful example I can verify that before the change: //third_party/WebKit/public:mojo_bindings_blink has a ...
4 years, 3 months ago (2016-09-09 22:34:32 UTC) #4
yzshen1
LGTM!!
4 years, 3 months ago (2016-09-09 22:59:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328873004/1
4 years, 3 months ago (2016-09-09 23:00:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-10 00:44:40 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 00:47:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a803c034985e873747aebb91769258a7842cac69
Cr-Commit-Position: refs/heads/master@{#417782}

Powered by Google App Engine
This is Rietveld 408576698