Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2328873003: Subzero: Fix a build error. Also reformat. (Closed)

Created:
4 years, 3 months ago by Jim Stichnoth
Modified:
4 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/IceInstX86BaseImpl.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/IceMemory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceMemory.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 3 months ago (2016-09-09 16:18:30 UTC) #3
nicolascapens1
LGTM
4 years, 3 months ago (2016-09-09 16:27:15 UTC) #4
Jim Stichnoth
4 years, 3 months ago (2016-09-09 16:29:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d5b6627479ee560ff50e4f0284e78c8d0111258 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698