Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: experimental/webtry/DESIGN.md

Issue 232883004: Flesh out the list of includes, also fix up README markdown (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | experimental/webtry/templates/template.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/webtry/DESIGN.md
diff --git a/experimental/webtry/DESIGN.md b/experimental/webtry/DESIGN.md
index ddc26f538cba6e18cbb71d13642d0d421f1b2f1f..66c7f1f7986537a33f4d099e8e1aab257756a6c6 100644
--- a/experimental/webtry/DESIGN.md
+++ b/experimental/webtry/DESIGN.md
@@ -25,7 +25,7 @@ for example runtime is limited to 5s of CPU.
User submitted code is also restricted in the following ways:
* Limited to 10K of code total.
- * No preprocessor use is allowed (no lines can begin with \s*#).
+ * No preprocessor use is allowed (no lines can begin with #includes).
Architecture
@@ -34,36 +34,36 @@ Architecture
The server runs on GCE, and consists of a Go Web Server that calls out to the
c++ compiler and executes code in a chroot jail. See the diagram below:
-                           
-   +–––––––––––––+         
-   |             |         
-   |  Browser    |         
-   |             |         
-   +––––––+––––––+         
-          |                
-   +––––––+––––––+         
-   |             |         
-   |             |         
-   | Web Server  |         
-   |             |         
-   |   (Go)      |         
-   |             |         
-   |             |         
-   +–––––––+–––––+         
-           |               
-   +–––––––+––––––––––+    
-   | chroot jail      |    
-   |  +––––––––––––––+|    
-   |  | seccomp      ||    
-   |  |  +––––––––––+||    
-   |  |  |User code |||    
-   |  |  |          |||    
-   |  |  +----------+||    
-   |  +––------------+|    
-   |                  |    
-   +––––––––––––––––––+    
-                           
-                           
+                            
+    +–––––––––––––+         
+    |             |         
+    |  Browser    |         
+    |             |         
+    +––––––+––––––+         
+           |                
+    +––––––+––––––+         
+    |             |         
+    |             |         
+    | Web Server  |         
+    |             |         
+    |   (Go)      |         
+    |             |         
+    |             |         
+    +–––––––+–––––+         
+            |               
+    +–––––––+––––––––––+    
+    | chroot jail      |    
+    |  +––––––––––––––+|    
+    |  | seccomp      ||    
+    |  |  +––––––––––+||    
+    |  |  |User code |||    
+    |  |  |          |||    
+    |  |  +––––––––––+||    
+    |  +––––––––––––––+|    
+    |                  |    
+    +––––––––––––––––––+    
+                            
+
The user code is expanded into a simple template and linked against libskia
and a couple other .o files that contain main() and the code that sets up the
seccomp and rlimit restrictions. This code also sets up the SkCanvas that is
« no previous file with comments | « no previous file | experimental/webtry/templates/template.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698