Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 232883003: Some tests and simplified TransitionArray copying (Closed)

Created:
6 years, 8 months ago by mvstanton
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Some tests and simplified TransitionArray copying Tests for verifying that we deal correctly with shrinking transition arrays while allocating a copy of one. Also, we can rely on a transition array only shrinking and not disappearing during gc while copying one. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20710

Patch Set 1 : Patch one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -19 lines) Patch
M src/objects.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/transitions.cc View 1 chunk +4 lines, -19 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +137 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Toon, Here is the test I was talking about, and I was able to ...
6 years, 8 months ago (2014-04-11 08:00:43 UTC) #1
Toon Verwaest
lgtm
6 years, 8 months ago (2014-04-11 08:34:55 UTC) #2
mvstanton
6 years, 8 months ago (2014-04-14 08:58:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20710 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698