Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: milo/appengine/buildbot/html.go

Issue 2328733002: Milo: Add ?limit= support to builders (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbot/html.go
diff --git a/milo/appengine/buildbot/html.go b/milo/appengine/buildbot/html.go
index 6d9e24418341a5635223aaa04039c2ae0d9a97bc..ba8e007479ea61641f4dd609a8b8338ce15d02ad 100644
--- a/milo/appengine/buildbot/html.go
+++ b/milo/appengine/buildbot/html.go
@@ -94,8 +94,15 @@ func (b Builder) Render(c context.Context, r *http.Request, p httprouter.Params)
Code: http.StatusBadRequest,
}
}
+ limit, err := settings.GetLimit(r)
+ if err != nil {
+ return nil, err
+ }
+ if limit < 0 {
+ limit = 25
+ }
- result, err := builderImpl(c, master, builder)
+ result, err := builderImpl(c, master, builder, limit)
if err != nil {
return nil, err
}

Powered by Google App Engine
This is Rietveld 408576698