Issue 232873002: Partially fix semantics of Array.push()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232873002: Partially fix semantics of Array.push() (Closed)

Created:
6 years, 8 months ago by danno

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev, Michael Starzinger

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Partially fix semantics of Array.push() Semantics of elements accessors are now preserved in all optimized code paths through Array.push(). Previously it was possible to have inconsistent behavior between optimized and unoptimized code, and there were cases where element accessors were completely ingored. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20655

Patch Set 1 #

Patch Set 2 : Fix internal RegExp use of naked Array #

Patch Set 3 : Add missing test case #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -4 lines)			Patch
M	src/builtins.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1	2 chunks	+16 lines, -2 lines	0 comments	Download
M	src/string.js	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
A	test/mjsunit/array-push2.js	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	test/mjsunit/array-push3.js	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	test/mjsunit/array-push4.js	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download
A	test/mjsunit/array-push5.js	View	1 2	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

6 years, 8 months ago (2014-04-10 13:18:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r20655 (presubmit successful).

Expand Messages | Collapse Messages