Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2328673003: [profiler] Add two CpuProfileNode API functions to allow thread safe access to the node. (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add two CpuProfileNode API functions to allow thread safe access to the node. GetFunctionNameStr and GetScriptResourceNameStr can be called from a thread other than isolate VM thread unlike their conterparts GetFunctionName and GetScriptResourceName. BUG=406277 Committed: https://crrev.com/5465c25cea64684fb8cc94a32208b3fac38fbdf2 Cr-Commit-Position: refs/heads/master@{#39313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M include/v8-profiler.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/api.cc View 3 chunks +8 lines, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
alph
ptal
4 years, 3 months ago (2016-09-09 08:54:07 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-09 13:20:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328673003/1
4 years, 3 months ago (2016-09-09 15:48:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 15:50:29 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 15:51:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5465c25cea64684fb8cc94a32208b3fac38fbdf2
Cr-Commit-Position: refs/heads/master@{#39313}

Powered by Google App Engine
This is Rietveld 408576698