Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2328663002: Revert of Checking for valid colorType, alphaType, colorSpace in SkCodec (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
Reviewers:
scroggo, Brian Osman
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Checking for valid colorType, alphaType, colorSpace in SkCodec (patchset #2 id:100001 of https://codereview.chromium.org/2319293003/ ) Reason for revert: Broken perf bots Original issue's description: > Checking for valid colorType, alphaType, colorSpace in SkCodec > > * Refactor to share code between SkPngCodec and SkWebpCodec > * Didn't end up sharing with SkJpegCodec but did refactor > that code a bit > * Disallow conversions to F16 with non-linear color spaces > * Fail to decode if we fail to create a SkColorSpaceXform > (should be an assert soon). We used to fallback on a > legacy decode if we failed to create the transform. > * A bunch of name changes > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293003 > > Committed: https://skia.googlesource.com/skia/+/7a9900d6d34e437bb24beb5524a1f6488ae138c9 TBR=scroggo@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/85c922acec37726ac64e9be9a79de697c677f35d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -114 lines) Patch
M dm/DMSrcSink.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/android/SkBitmapRegionCodec.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/codec/SkBmpCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkBmpMaskCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkBmpRLECodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkBmpStandardCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkCodecPriv.h View 2 chunks +2 lines, -40 lines 0 comments Download
M src/codec/SkGifCodec.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/codec/SkJpegCodec.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 7 chunks +26 lines, -19 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 5 chunks +34 lines, -5 lines 0 comments Download
M src/codec/SkRawCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkWebpCodec.cpp View 2 chunks +23 lines, -4 lines 0 comments Download
M tests/CodecTest.cpp View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Checking for valid colorType, alphaType, colorSpace in SkCodec
4 years, 3 months ago (2016-09-08 17:54:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328663002/1
4 years, 3 months ago (2016-09-08 17:54:26 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:54:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/85c922acec37726ac64e9be9a79de697c677f35d

Powered by Google App Engine
This is Rietveld 408576698