[Extensions] Convert some ChromeSyncExtensionFunctions

[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- autotest_private
- content_settings
- context_menus

BUG=634140
Committed: https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95
Cr-Commit-Position: refs/heads/master@{#417666}

[Devlin, 2016-09-08 22:48:34]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 22:49:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:33:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:33:19]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-09 00:13:47]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-09-09 00:13:47]

Another one for you, Antony.

[asargent_no_longer_on_chrome, 2016-09-09 05:09:34]

lgtm

https://codereview.chromium.org/2328643003/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/content_settings/content_settings_api.cc
(right):

https://codereview.chromium.org/2328643003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/content_settings/content_settings_api.cc:138:
Profile* profile = ChromeExtensionFunctionDetails(this).GetProfile();
Out of curiousity, why do we have this
ChromeExtensionFunctionDetails::GetProfile method instead of just calling:

Profile* profile = Profile::FromBrowserContext(browser_context()) 

?

[Devlin, 2016-09-09 18:27:26]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 18:28:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-09-09 18:29:04]

https://codereview.chromium.org/2328643003/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/content_settings/content_settings_api.cc
(right):

https://codereview.chromium.org/2328643003/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/content_settings/content_settings_api.cc:138:
Profile* profile = ChromeExtensionFunctionDetails(this).GetProfile();
On 2016/09/09 05:09:34, Antony Sargent wrote:
> Out of curiousity, why do we have this
> ChromeExtensionFunctionDetails::GetProfile method instead of just calling:
> 
> Profile* profile = Profile::FromBrowserContext(browser_context()) 
> 
> ?

Excellent question!  For some reason, I thought we did something more
complicated in GetProfile().  We don't.  Updated these call sites, and I'll work
to remove it in a separate patch.  No reason to have an alias function lying
around.

[commit-bot: I haz the power, 2016-09-09 19:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 19:17:38]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-09 19:20:59]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-09-09 19:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2328643003/#ps20001
(title: "Remove GetProfile() usage")

[commit-bot: I haz the power, 2016-09-09 19:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:25:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 19:28:50]

Description was changed from

==========
[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- autotest_private
- content_settings
- context_menus

BUG=634140
==========

to

==========
[Extensions] Convert some ChromeSyncExtensionFunctions

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- autotest_private
- content_settings
- context_menus

BUG=634140

Committed: https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95
Cr-Commit-Position: refs/heads/master@{#417666}
==========

[commit-bot: I haz the power, 2016-09-09 19:28:51]

Patchset 2 (id:??) landed as
https://crrev.com/e46ef7309a36681bb8d59b96a9f8b6daddad3d95
Cr-Commit-Position: refs/heads/master@{#417666}