Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2328643002: [DevTools] Migrate XMLView to TreeOutlineInShadow. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
allada
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate XMLView to TreeOutlineInShadow. This is a step towards turning all tree outlines into independent web components, removing global styles related to it and allowing more components to encapsulate their inner details. BUG=none Committed: https://crrev.com/0d64c1467f6c51de3ae4e2749a6d488672f5dd44 Cr-Commit-Position: refs/heads/master@{#417495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -78 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/XMLView.js View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/network/xmlTree.css View 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/xmlView.css View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-08 17:48:26 UTC) #2
allada
lgtm. Please update description to be <80 characters per line.
4 years, 3 months ago (2016-09-08 23:58:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328643002/1
4 years, 3 months ago (2016-09-09 00:04:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/221658) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-09 00:08:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328643002/1
4 years, 3 months ago (2016-09-09 00:39:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/221691)
4 years, 3 months ago (2016-09-09 00:47:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328643002/1
4 years, 3 months ago (2016-09-09 00:55:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/294761)
4 years, 3 months ago (2016-09-09 00:57:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328643002/1
4 years, 3 months ago (2016-09-09 01:59:01 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 03:29:51 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 03:33:55 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d64c1467f6c51de3ae4e2749a6d488672f5dd44
Cr-Commit-Position: refs/heads/master@{#417495}

Powered by Google App Engine
This is Rietveld 408576698