Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2328633004: lazy allocation and early release memory in QuicStreamSequencerBuffer. Protected by --quic_reduce_s… (Closed)

Created:
4 years, 3 months ago by danzh1
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

lazy allocation and early release memory in QuicStreamSequencerBuffer. Protected by --quic_reduce_sequencer_buffer_memory_life_time. Postpone the instantiation of the underlying buffer in QuicStreamSequencerBuffer till receiving first data frame, this will make GET request cheaper. And release the memory as soon as the stream is read closed. Merge internal change: 131985218 and 132338729 R=rch@chromium.org BUG=635041 Committed: https://crrev.com/2f64ff9a9ff6d76a2e4b755d3e01b79936759b6f Cr-Commit-Position: refs/heads/master@{#417947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -6 lines) Patch
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.h View 3 chunks +12 lines, -1 line 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.cc View 4 chunks +26 lines, -4 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_test.cc View 6 chunks +37 lines, -1 line 0 comments Download
M net/quic/core/reliable_quic_stream.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
danzh1
4 years, 3 months ago (2016-09-09 20:12:38 UTC) #1
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-09 21:07:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328633004/1
4 years, 3 months ago (2016-09-12 14:21:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 15:34:35 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 15:36:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f64ff9a9ff6d76a2e4b755d3e01b79936759b6f
Cr-Commit-Position: refs/heads/master@{#417947}

Powered by Google App Engine
This is Rietveld 408576698