Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2055)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListItem.cpp

Issue 2328623003: Fix incorrectly positioned block element inside list-style-position:inside item (Closed)
Patch Set: update aria-owns-expected-mac.txt Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/pasteboard/drag-drop-list-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutListItem.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
index badb3a06f52091495cb3760cd7c472f975a045fc..b0f7801b64c6df59fdd6ea93c674864b6a0a8e00 100644
--- a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
@@ -299,7 +299,8 @@ bool LayoutListItem::updateMarkerLocation()
ASSERT(m_marker);
LayoutObject* markerParent = m_marker->parent();
- LayoutObject* lineBoxParent = getParentOfFirstLineBox(this, m_marker);
+ // list-style-position:inside makes the ::marker pseudo an ordinary position:static element that should be attached to LayoutListItem block.
+ LayoutObject* lineBoxParent = m_marker->isInside() ? this : getParentOfFirstLineBox(this, m_marker);
if (!lineBoxParent) {
// If the marker is currently contained inside an anonymous box, then we
// are the only item in that anonymous box (since no line box parent was
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/pasteboard/drag-drop-list-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698