test/cctest/asmjs/test-asm-typer.cc - Issue 2328593002: [Parser] Don't internalize on-the-fly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/asmjs/test-asm-typer.cc

Issue 2328593002: [Parser] Don't internalize on-the-fly. (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/asmjs/test-asm-typer.cc

diff --git a/test/cctest/asmjs/test-asm-typer.cc b/test/cctest/asmjs/test-asm-typer.cc

index 84063a05d0e5abcf205f99b00ca795dcd311e50c..1fe3c17ff5fb8875b4d29ea790a4e11500e771dc 100644

--- a/test/cctest/asmjs/test-asm-typer.cc

+++ b/test/cctest/asmjs/test-asm-typer.cc

@@ -276,6 +276,7 @@ class AsmTyperHarnessBuilder {

private:

Variable* DeclareVariable(VariableName var_name) {

auto* name_ast_string = ast_value_factory_.GetOneByteString(var_name.name_);

+ ast_value_factory_.Internalize(isolate_);

return var_name.mode_ == DYNAMIC_GLOBAL

? outer_scope_->DeclareDynamicGlobal(name_ast_string,

NORMAL_VARIABLE)

« no previous file with comments | « src/parsing/rewriter.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »