Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: src/parsing/parser.cc

Issue 2328593002: [Parser] Don't internalize on-the-fly. (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/rewriter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index 36c17091193b55b791205100ac04933eab7d731b..a40ec198e17ce87d0ad412fa8464bd10e0243af8 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -4167,7 +4167,7 @@ void Parser::HandleSourceURLComments(Isolate* isolate, Handle<Script> script) {
void Parser::Internalize(Isolate* isolate, Handle<Script> script, bool error) {
- // Internalize strings.
+ // Internalize strings and values.
ast_value_factory()->Internalize(isolate);
// Error processing.
@@ -4234,7 +4234,6 @@ bool Parser::Parse(ParseInfo* info) {
info->set_literal(result);
Internalize(isolate, info->script(), result == NULL);
- DCHECK(ast_value_factory()->IsInternalized());
return (result != NULL);
}
@@ -5827,13 +5826,6 @@ Statement* Parser::FinalizeForOfStatement(ForOfStatement* loop,
return final_loop;
}
-#ifdef DEBUG
-void Parser::Print(AstNode* node) {
- ast_value_factory()->Internalize(Isolate::Current());
- node->Print(Isolate::Current());
-}
-#endif // DEBUG
-
#undef CHECK_OK
#undef CHECK_OK_VOID
#undef CHECK_FAILED
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/rewriter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698