Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2328563002: Revert of Use -fno-delete-null-pointer-checks with gcc builds (Closed)

Created:
4 years, 3 months ago by ofrobots
Modified:
4 years, 3 months ago
CC:
Michael Achenbach, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use -fno-delete-null-pointer-checks with gcc builds (patchset #2 id:20001 of https://codereview.chromium.org/2310513002/ ) Reason for revert: Fails on MIPS: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/3653 Original issue's description: > Use -fno-delete-null-pointer-checks with gcc builds > > R=bmeurer@chromium.org, jochen@chromium.org, machenbach@chromium.org > BUG=v8:3782 > > Committed: https://crrev.com/dbefc8ee2e9ee6e41b83f3d09c788c34bc923b43 > Cr-Commit-Position: refs/heads/master@{#39286} TBR=jochen@chromium.org,bmeurer@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3782 Committed: https://crrev.com/20d427a1e22776762e1382dd4c01dc0a896a13b4 Cr-Commit-Position: refs/heads/master@{#39287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M gypfiles/toolchain.gypi View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ofrobots
Created Revert of Use -fno-delete-null-pointer-checks with gcc builds
4 years, 3 months ago (2016-09-08 15:55:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328563002/1
4 years, 3 months ago (2016-09-08 15:55:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 15:55:48 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 15:56:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20d427a1e22776762e1382dd4c01dc0a896a13b4
Cr-Commit-Position: refs/heads/master@{#39287}

Powered by Google App Engine
This is Rietveld 408576698