|
|
Descriptioncc/images: Add more disabled-by-default traces to GPU image controller.
This patch adds traces to GpuImageDecodeController in an effort to
better understand the performance characteristics of the code. These
traces are disabled by default.
R=ericrk@chromium.org, enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327
Committed: https://crrev.com/d3aae3acb0950a4438b058abf70fa0b6fbaf93f5
Cr-Original-Commit-Position: refs/heads/master@{#417651}
Cr-Commit-Position: refs/heads/master@{#418007}
Patch Set 1 #
Messages
Total messages: 20 (7 generated)
Description was changed from ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org ========== to ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Please take a look.
lgtm
The CQ bit was checked by vmpstr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327 Cr-Commit-Position: refs/heads/master@{#417651} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327 Cr-Commit-Position: refs/heads/master@{#417651}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2325263002/ by dmurph@chromium.org. The reason for reverting is: causing a bunch of failureson Linux ChromiumOS Tests.
Message was sent while issue was closed.
On 2016/09/09 22:11:28, dmurph wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2325263002/ by mailto:dmurph@chromium.org. > > The reason for reverting is: causing a bunch of failureson > Linux ChromiumOS Tests. dmurph@ do you have an example build where this is failing?
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2320883005/ by dmurph@chromium.org. The reason for reverting is: https://bugs.chromium.org/p/chromium/issues/detail?id=645621 BUG=645621 .
Message was sent while issue was closed.
On 2016/09/09 22:36:54, vmpstr wrote: > On 2016/09/09 22:11:28, dmurph wrote: > > A revert of this CL (patchset #1 id:1) has been created in > > https://codereview.chromium.org/2325263002/ by mailto:dmurph@chromium.org. > > > > The reason for reverting is: causing a bunch of failureson > > Linux ChromiumOS Tests. > > dmurph@ do you have an example build where this is failing? probably false alarm, sorry. Sherrif-o-matic pointed at this one. everything has been breaking :(
Message was sent while issue was closed.
On 2016/09/10 01:35:38, dmurph wrote: > On 2016/09/09 22:36:54, vmpstr wrote: > > On 2016/09/09 22:11:28, dmurph wrote: > > > A revert of this CL (patchset #1 id:1) has been created in > > > https://codereview.chromium.org/2325263002/ by mailto:dmurph@chromium.org. > > > > > > The reason for reverting is: causing a bunch of failureson > > > Linux ChromiumOS Tests. > > > > dmurph@ do you have an example build where this is failing? > > probably false alarm, sorry. Sherrif-o-matic pointed at this one. everything has > been breaking :( I'm going to reland this. The reasoning is that this is adding disabled by default traces, and it's very unlikely to be breaking tests. If the problem indeed persists, please revert and let me know which tests are failing so that I can investigate in more details.
Message was sent while issue was closed.
Description was changed from ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327 Cr-Commit-Position: refs/heads/master@{#417651} ========== to ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327 Cr-Commit-Position: refs/heads/master@{#417651} ==========
The CQ bit was checked by vmpstr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327 Cr-Commit-Position: refs/heads/master@{#417651} ========== to ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327 Cr-Commit-Position: refs/heads/master@{#417651} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327 Cr-Commit-Position: refs/heads/master@{#417651} ========== to ========== cc/images: Add more disabled-by-default traces to GPU image controller. This patch adds traces to GpuImageDecodeController in an effort to better understand the performance characteristics of the code. These traces are disabled by default. R=ericrk@chromium.org, enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1fc46747f05525b9565e223f807e2b9fcc38c327 Committed: https://crrev.com/d3aae3acb0950a4438b058abf70fa0b6fbaf93f5 Cr-Original-Commit-Position: refs/heads/master@{#417651} Cr-Commit-Position: refs/heads/master@{#418007} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d3aae3acb0950a4438b058abf70fa0b6fbaf93f5 Cr-Commit-Position: refs/heads/master@{#418007} |