mash: Fix shelf on second display appearing in wrong position

mash: Fix shelf on second display appearing in wrong position

NativeWidgetMus::SetBounds() was not correcting for the display origin.

Also fix NativeWidgetMus::GetBoundsInScreen(), which had the same problem.

BUG=645291, 644895
TEST=run mash with --multi-display, shelf appears on second display

Committed: https://crrev.com/fa697bc0a0332fc8ab5684f4c4366797d4b5aeab
Cr-Commit-Position: refs/heads/master@{#417505}

[James Cook, 2016-09-08 23:28:14]

Description was changed from

==========
WIP: mash: Fix shelf on second display appearing in wrong position

BUG=
==========

to

==========
mash: Fix shelf on second display appearing in wrong position

NativeWidgetMus::SetBounds() was not correcting for the display origin.

Also fix NativeWidgetMus::GetBoundsInScreen(), which had the same problem.

BUG=645291,644895
TEST=run mash with --multi-display, shelf appears on second display
==========

[James Cook, 2016-09-08 23:28:19]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 23:28:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-08 23:30:19]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-09-08 23:30:20]

sky, please take a look. I don't have a test for this because there isn't yet a
way to set up multiple displays in tests in mus -- I think kylechar is working
on this. We'll get coverage for free as more higher-level tests are ported to
mus.

[commit-bot: I haz the power, 2016-09-08 23:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:36:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-09-08 23:52:57]

I actually mostly have multiple displays working for tests based on WmTestBase.
I got hung up chasing some shutdown bugs. Will try and revive soon.

LGTM

https://codereview.chromium.org/2328523003/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/2328523003/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:952: void NativeWidgetMus::SetBounds(const
gfx::Rect& bounds_in_screen) {
Rename arg in header to match.

[James Cook, 2016-09-09 03:55:36]

Thanks for the review.

https://codereview.chromium.org/2328523003/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/2328523003/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:952: void NativeWidgetMus::SetBounds(const
gfx::Rect& bounds_in_screen) {
On 2016/09/08 23:52:56, sky wrote:
> Rename arg in header to match.

Done.

[James Cook, 2016-09-09 03:55:40]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-09-09 03:55:41]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2328523003/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-09-09 03:56:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 04:44:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-09 04:46:18]

Description was changed from

==========
mash: Fix shelf on second display appearing in wrong position

NativeWidgetMus::SetBounds() was not correcting for the display origin.

Also fix NativeWidgetMus::GetBoundsInScreen(), which had the same problem.

BUG=645291,644895
TEST=run mash with --multi-display, shelf appears on second display
==========

to

==========
mash: Fix shelf on second display appearing in wrong position

NativeWidgetMus::SetBounds() was not correcting for the display origin.

Also fix NativeWidgetMus::GetBoundsInScreen(), which had the same problem.

BUG=645291,644895
TEST=run mash with --multi-display, shelf appears on second display

Committed: https://crrev.com/fa697bc0a0332fc8ab5684f4c4366797d4b5aeab
Cr-Commit-Position: refs/heads/master@{#417505}
==========

[commit-bot: I haz the power, 2016-09-09 04:46:19]

Patchset 3 (id:??) landed as
https://crrev.com/fa697bc0a0332fc8ab5684f4c4366797d4b5aeab
Cr-Commit-Position: refs/heads/master@{#417505}