[JSON] call replacer function with correct holder in JSON.stringify

[JSON] call replacer function with correct holder in JSON.stringify

BUG=v8:5363
R=adamk@chromium.org, littledan@chromium.org, cbruni@chromium.org

Committed: https://crrev.com/646f1f0a4a5ba38dfb7f7333f6914fce5193ce1d
Cr-Commit-Position: refs/heads/master@{#39291}

[caitp, 2016-09-08 14:48:57]

Hi, PTAL

A potential improvement would be to have a shorter-lived handle for the
initial_value in the `toJSON` branch of Serialize_, but it may not matter much.

[caitp, 2016-09-08 14:48:57]

Hi, PTAL

A potential improvement would be to have a shorter-lived handle for the
initial_value in the `toJSON` branch of Serialize_, but it may not matter much.

[caitp, 2016-09-08 14:50:53]

The CQ bit was checked by caitp@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 14:50:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 15:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 15:14:33]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-09-08 15:45:26]

lgtm with nit

https://codereview.chromium.org/2328523002/diff/1/src/json-stringifier.cc
File src/json-stringifier.cc (right):

https://codereview.chromium.org/2328523002/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:215: Handle<Object> object, Handle<Object> key,
Handle<Object> initial_value) {
nit: I'd prefer value vs. object and initial_object vs. initial_value WDYT?

https://codereview.chromium.org/2328523002/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

https://codereview.chromium.org/2328523002/diff/1/src/json-stringifier.h#newc...
src/json-stringifier.h:35: 
nit: I'd prefer value vs. object and initial_object vs. initial_value (the same
for CurrentHolder and in the .cc as well)

[caitp, 2016-09-08 15:47:24]

https://codereview.chromium.org/2328523002/diff/1/src/json-stringifier.cc
File src/json-stringifier.cc (right):

https://codereview.chromium.org/2328523002/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:215: Handle<Object> object, Handle<Object> key,
Handle<Object> initial_value) {
On 2016/09/08 15:45:26, Camillo Bruni wrote:
> nit: I'd prefer value vs. object and initial_object vs. initial_value WDYT?

sgtm for both (or maybe 'initial_holder' to match spec language closer)

[Camillo Bruni, 2016-09-08 15:48:43]

On 2016/09/08 at 15:47:24, caitp wrote:
> https://codereview.chromium.org/2328523002/diff/1/src/json-stringifier.cc
> File src/json-stringifier.cc (right):
> 
>
https://codereview.chromium.org/2328523002/diff/1/src/json-stringifier.cc#new...
> src/json-stringifier.cc:215: Handle<Object> object, Handle<Object> key,
Handle<Object> initial_value) {
> On 2016/09/08 15:45:26, Camillo Bruni wrote:
> > nit: I'd prefer value vs. object and initial_object vs. initial_value WDYT?
> 
> sgtm for both (or maybe 'initial_holder' to match spec language closer)

sounds good.

[caitp, 2016-09-08 17:31:16]

The CQ bit was checked by caitp@igalia.com

[caitp, 2016-09-08 17:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2328523002/#ps20001
(title: "Nits and more tests")

[commit-bot: I haz the power, 2016-09-08 17:31:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:57:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 17:58:03]

Description was changed from

==========
[JSON] call replacer function with correct holder in JSON.stringify

BUG=v8:5363
R=adamk@chromium.org, littledan@chromium.org, cbruni@chromium.org
==========

to

==========
[JSON] call replacer function with correct holder in JSON.stringify

BUG=v8:5363
R=adamk@chromium.org, littledan@chromium.org, cbruni@chromium.org

Committed: https://crrev.com/646f1f0a4a5ba38dfb7f7333f6914fce5193ce1d
Cr-Commit-Position: refs/heads/master@{#39291}
==========

[commit-bot: I haz the power, 2016-09-08 17:58:08]

Patchset 2 (id:??) landed as
https://crrev.com/646f1f0a4a5ba38dfb7f7333f6914fce5193ce1d
Cr-Commit-Position: refs/heads/master@{#39291}