Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2328503002: [heap] Fix debug check in ShrinkToHighWaterMark (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix debug check in ShrinkToHighWaterMark BUG= R=ulan@chromium.org Committed: https://crrev.com/5c3b6ca8d90142602e158bc2a6d0596edbde02d3 Cr-Commit-Position: refs/heads/master@{#39284}

Patch Set 1 #

Patch Set 2 : reorder #

Patch Set 3 : better order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/heap/spaces.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
ulan
lgtm
4 years, 3 months ago (2016-09-08 14:30:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328503002/60001
4 years, 3 months ago (2016-09-08 15:03:51 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-08 15:06:12 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 15:06:25 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5c3b6ca8d90142602e158bc2a6d0596edbde02d3
Cr-Commit-Position: refs/heads/master@{#39284}

Powered by Google App Engine
This is Rietveld 408576698