Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2328493002: Remove the tool to disable the outdated build detector for organic installs of Chrome. (Closed)

Created:
4 years, 3 months ago by grt (UTC plus 2)
Modified:
4 years, 3 months ago
Reviewers:
S. Ganesh, Nico, Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the tool to disable the outdated build detector for organic installs of Chrome. It served its purpose and is no longer needed. This is a simple revert of r414123, r413080, r412464, r411775, and r410031. BUG=623986 Committed: https://crrev.com/178d53ff3619b758335beb2d0fa91a05e12f6137 Cr-Commit-Position: refs/heads/master@{#417516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -935 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/google/google_brand.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/BUILD.gn View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/constants.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/constants.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector_exe_version.rc.version View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector_main.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/disable_outdated_build_detector_unittest.cc View 1 chunk +0 lines, -214 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/google_update_integration.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/google_update_integration.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/google_update_integration_unittest.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/tools/disable_outdated_build_detector/run_all_unittests.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 10 chunks +0 lines, -60 lines 0 comments Download
M testing/buildbot/chromium.win.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
grt (UTC plus 2)
PTAL. I don't think there's much not to like here. :-)
4 years, 3 months ago (2016-09-08 12:58:33 UTC) #5
Nico
lgtm
4 years, 3 months ago (2016-09-08 13:12:01 UTC) #6
S. Ganesh
lgtm
4 years, 3 months ago (2016-09-08 16:32:36 UTC) #9
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-08 21:55:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328493002/1
4 years, 3 months ago (2016-09-09 06:25:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 06:28:34 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 06:30:35 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/178d53ff3619b758335beb2d0fa91a05e12f6137
Cr-Commit-Position: refs/heads/master@{#417516}

Powered by Google App Engine
This is Rietveld 408576698