Fix formats mismatch in validate_multisample_buffer_allocation

The formats of read and draw framebuffers should be identical according to spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/361419c87294053f0fd1701431053d19253710e5
Cr-Commit-Position: refs/heads/master@{#417831}

[jchen10, 2016-09-08 08:59:12]

Description was changed from

==========
Relex RGB8 multisample renderbuffer check on MacOSX

Mac driver is too fragile to pass this integrity verification.

BUG=645043
==========

to

==========
Relex RGB8 multisample renderbuffer check on MacOSX

Mac driver is too fragile to pass this integrity verification.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jchen10, 2016-09-08 08:59:13]

Description was changed from

==========
Relex RGB8 multisample renderbuffer check on MacOSX

Mac driver is too fragile to pass this integrity verification.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Relex RGB8 multisample renderbuffer check on MacOSX

Mac driver is too fragile to pass this integrity verification.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[jchen10, 2016-09-08 08:59:19]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 08:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 09:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 09:07:31]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[jchen10, 2016-09-08 10:59:34]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 10:59:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 12:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 12:04:11]

Dry run: This issue passed the CQ dry run.

[jchen10, 2016-09-08 12:12:45]

Description was changed from

==========
Relex RGB8 multisample renderbuffer check on MacOSX

Mac driver is too fragile to pass this integrity verification.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Relex RGB8 multisample renderbuffer check on MacOSX

Mac driver is too fragile to pass this integrity verification.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[jchen10, 2016-09-08 12:12:45]

jie.a.chen@intel.com changed reviewers:
+ kbr@chromium.org, qiankun.miao@intel.com, yunchao.he@intel.com,
zmo@chromium.org

[jchen10, 2016-09-08 12:13:10]

Please take a look!

[Zhenyao Mo, 2016-09-08 16:44:20]

On 2016/09/08 12:13:10, jchen10 wrote:
> Please take a look!

What?! So multisampled RGB8 renderbuffer only fails because of this internal
validation? Could you dig further and see which part fails? Blit? We need to get
to the bottom of this and decide which features to remove from WebGL2.

[jchen10, 2016-09-09 00:55:18]

On 2016/09/08 16:44:20, Zhenyao Mo wrote:
> On 2016/09/08 12:13:10, jchen10 wrote:
> > Please take a look!
> 
> What?! So multisampled RGB8 renderbuffer only fails because of this internal
> validation? Could you dig further and see which part fails? Blit? We need to
get
> to the bottom of this and decide which features to remove from WebGL2.

Yes, It's this Blit,
https://chromium.googlesource.com/chromium/src.git/+/master/gpu/command_buffe...

[jchen10, 2016-09-09 01:49:27]

On 2016/09/09 00:55:18, jchen10 wrote:
> On 2016/09/08 16:44:20, Zhenyao Mo wrote:
> > On 2016/09/08 12:13:10, jchen10 wrote:
> > > Please take a look!
> > 
> > What?! So multisampled RGB8 renderbuffer only fails because of this internal
> > validation? Could you dig further and see which part fails? Blit? We need to
> get
> > to the bottom of this and decide which features to remove from WebGL2.
> 
> Yes, It's this Blit,
>
https://chromium.googlesource.com/chromium/src.git/+/master/gpu/command_buffe...

Seemingly it has same root cause as this known issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=484203#c19

[Zhenyao Mo, 2016-09-09 02:43:34]

On 2016/09/09 01:49:27, jchen10 wrote:
> On 2016/09/09 00:55:18, jchen10 wrote:
> > On 2016/09/08 16:44:20, Zhenyao Mo wrote:
> > > On 2016/09/08 12:13:10, jchen10 wrote:
> > > > Please take a look!
> > > 
> > > What?! So multisampled RGB8 renderbuffer only fails because of this
internal
> > > validation? Could you dig further and see which part fails? Blit? We need
to
> > get
> > > to the bottom of this and decide which features to remove from WebGL2.
> > 
> > Yes, It's this Blit,
> >
>
https://chromium.googlesource.com/chromium/src.git/+/master/gpu/command_buffe...
> 
> Seemingly it has same root cause as this known issue:
> https://bugs.chromium.org/p/chromium/issues/detail?id=484203#c19

I don't think we should add another driver bug workaround for this.  Simply, we
should limit the original workaround VerifyMultisampleRenderbufferIntegrity to
older macosx (say, version < 10.11) and then add the failing test case to
conformance2/rendering/rgb-format-support.html.

I don't think it's the same cause as crbug.com/484203.  That is violating the
spec, this only fails on Mac AMD, so it looks like a driver bug to me.

[Zhenyao Mo, 2016-09-09 02:44:18]

On 2016/09/09 02:43:34, Zhenyao Mo wrote:
> On 2016/09/09 01:49:27, jchen10 wrote:
> > On 2016/09/09 00:55:18, jchen10 wrote:
> > > On 2016/09/08 16:44:20, Zhenyao Mo wrote:
> > > > On 2016/09/08 12:13:10, jchen10 wrote:
> > > > > Please take a look!
> > > > 
> > > > What?! So multisampled RGB8 renderbuffer only fails because of this
> internal
> > > > validation? Could you dig further and see which part fails? Blit? We
need
> to
> > > get
> > > > to the bottom of this and decide which features to remove from WebGL2.
> > > 
> > > Yes, It's this Blit,
> > >
> >
>
https://chromium.googlesource.com/chromium/src.git/+/master/gpu/command_buffe...
> > 
> > Seemingly it has same root cause as this known issue:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=484203#c19
> 
> I don't think we should add another driver bug workaround for this.  Simply,
we
> should limit the original workaround VerifyMultisampleRenderbufferIntegrity to
> older macosx (say, version < 10.11) and then add the failing test case to
> conformance2/rendering/rgb-format-support.html.
> 
> I don't think it's the same cause as crbug.com/484203.  That is violating the
> spec, this only fails on Mac AMD, so it looks like a driver bug to me.

Forgot to include the workaround I mentioned:
validate_multisample_buffer_allocation

[jchen10, 2016-09-09 07:15:24]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 07:15:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jchen10, 2016-09-09 07:48:39]

Description was changed from

==========
Relex RGB8 multisample renderbuffer check on MacOSX

Mac driver is too fragile to pass this integrity verification.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
The formats of read and write framebuffers should be identical according to
spec.
This CL enforces this by using one validation texture for each format other than
all
formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[jchen10, 2016-09-09 07:51:39]

Description was changed from

==========
The formats of read and write framebuffers should be identical according to
spec.
This CL enforces this by using one validation texture for each format other than
all
formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
The formats of read and write framebuffers should be identical according to
spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-09 08:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 08:41:23]

Dry run: This issue passed the CQ dry run.

[jchen10, 2016-09-09 08:46:12]

Description was changed from

==========
The formats of read and write framebuffers should be identical according to
spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
The formats of read and draw framebuffers should be identical according to spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[jchen10, 2016-09-09 08:48:53]

It seems a chromium bug of formats mismatch. Both GL4.1 and ES3 specs are clear
on this that formats should be identical.

GL4.1 section 4.3.2
If SAMPLE_BUFFERS for either the read framebuffer or draw framebuffer is greater
 than  zero,  no  copy  is  performed  and  an INVALID_OPERATION error  is
generated if the dimensions of the source and destination rectangles provided to
BlitFramebuffer are not identical, if the formats of the read and draw
framebuffers are not identical, or if the values of SAMPLES for the read and
draw buffers are not identical.


ES3 section 4.3.2
If SAMPLE_BUFFERS for the read framebuffer is greater than zero, no copy is
performed and an INVALID_OPERATION error is generated if the formats of the read
and draw framebuffers are not identical or if the source and destination
rectangles are not defined with the same (X0, Y 0) and (X1, Y 1) bounds.

[Zhenyao Mo, 2016-09-09 18:53:52]

lgtm

Can you also remove deqp/functional/gles3/fbomultisample*  expectations from
Mac?

https://codereview.chromium.org/2328463002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2328463002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:7865: case GL_RGB:
This is incorrect. Can you fix it? RGB and RGBA are not valid format for
renderbuffer.

[jchen10, 2016-09-09 22:43:30]

On 2016/09/09 18:53:52, Zhenyao Mo wrote:
> lgtm
> 
> Can you also remove deqp/functional/gles3/fbomultisample*  expectations from
> Mac?
> 
>
https://codereview.chromium.org/2328463002/diff/20001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2328463002/diff/20001/gpu/command_buffer/serv...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:7865: case GL_RGB:
> This is incorrect. Can you fix it? RGB and RGBA are not valid format for
> renderbuffer.

Some depth cases of "fbomultisample*" still fail on my MacbookPro. I will
continue to look into them. So it's not eligible to remove it now at lease for
Intel Mac. I have no other Mac platforms, so I am not sure the status on them.

[jchen10, 2016-09-09 23:09:17]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 23:10:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 00:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:43:00]

Dry run: Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[Zhenyao Mo, 2016-09-10 02:28:17]

On 2016/09/09 22:43:30, jchen10 wrote:
> On 2016/09/09 18:53:52, Zhenyao Mo wrote:
> > lgtm
> > 
> > Can you also remove deqp/functional/gles3/fbomultisample*  expectations from
> > Mac?
> > 
> >
>
https://codereview.chromium.org/2328463002/diff/20001/gpu/command_buffer/serv...
> > File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> > 
> >
>
https://codereview.chromium.org/2328463002/diff/20001/gpu/command_buffer/serv...
> > gpu/command_buffer/service/gles2_cmd_decoder.cc:7865: case GL_RGB:
> > This is incorrect. Can you fix it? RGB and RGBA are not valid format for
> > renderbuffer.
> 
> Some depth cases of "fbomultisample*" still fail on my MacbookPro. I will
> continue to look into them. So it's not eligible to remove it now at lease for
> Intel Mac. I have no other Mac platforms, so I am not sure the status on them.

You can look at the mac_optional_gpu_tests_rel and for each gpu, search for "but
passed", and you will see all the tests that are marked as failure but pass.

You are right, so far these tests only pass on Mac AMD, but still fail on Mac
Intel and Mac NVidia.

[jchen10, 2016-09-10 03:54:49]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 03:55:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jchen10, 2016-09-10 04:32:52]

On 2016/09/10 02:28:17, Zhenyao Mo wrote:
> On 2016/09/09 22:43:30, jchen10 wrote:
> > On 2016/09/09 18:53:52, Zhenyao Mo wrote:
> > > lgtm
> > > 
> > > Can you also remove deqp/functional/gles3/fbomultisample*  expectations
from
> > > Mac?
> > > 
> > >
> >
>
https://codereview.chromium.org/2328463002/diff/20001/gpu/command_buffer/serv...
> > > File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2328463002/diff/20001/gpu/command_buffer/serv...
> > > gpu/command_buffer/service/gles2_cmd_decoder.cc:7865: case GL_RGB:
> > > This is incorrect. Can you fix it? RGB and RGBA are not valid format for
> > > renderbuffer.
> > 
> > Some depth cases of "fbomultisample*" still fail on my MacbookPro. I will
> > continue to look into them. So it's not eligible to remove it now at lease
for
> > Intel Mac. I have no other Mac platforms, so I am not sure the status on
them.
> 
> You can look at the mac_optional_gpu_tests_rel and for each gpu, search for
"but
> passed", and you will see all the tests that are marked as failure but pass.
> 
> You are right, so far these tests only pass on Mac AMD, but still fail on Mac
> Intel and Mac NVidia.

Good to know that. That's handy. Thanks!

[jchen10, 2016-09-10 04:35:13]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 04:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 07:25:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 07:25:34]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[jchen10, 2016-09-10 08:49:34]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 08:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 09:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 09:49:29]

Dry run: This issue passed the CQ dry run.

[jchen10, 2016-09-10 10:37:12]

The CQ bit was checked by jie.a.chen@intel.com

[jchen10, 2016-09-10 10:37:13]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2328463002/#ps60001
(title: "Update expectations.py")

[commit-bot: I haz the power, 2016-09-10 10:37:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 10:41:16]

Description was changed from

==========
The formats of read and draw framebuffers should be identical according to spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
The formats of read and draw framebuffers should be identical according to spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-10 10:41:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-10 10:43:20]

Description was changed from

==========
The formats of read and draw framebuffers should be identical according to spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
The formats of read and draw framebuffers should be identical according to spec.
This CL enforces this by using one validation texture for each format other
than all formats.

BUG=645043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/361419c87294053f0fd1701431053d19253710e5
Cr-Commit-Position: refs/heads/master@{#417831}
==========

[commit-bot: I haz the power, 2016-09-10 10:43:21]

Patchset 4 (id:??) landed as
https://crrev.com/361419c87294053f0fd1701431053d19253710e5
Cr-Commit-Position: refs/heads/master@{#417831}