blimp/engine/feature/geolocation/engine_geolocation_feature.h - Issue 2328453003: Makes use of EngineGeolocationFeature weak_ptr threadsafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/feature/geolocation/engine_geolocation_feature.h

Issue 2328453003: Makes use of EngineGeolocationFeature weak_ptr threadsafe. (Closed)

Patch Set: Addresses kmarshall's #3 comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/engine/feature/geolocation/engine_geolocation_feature.h

diff --git a/blimp/engine/feature/geolocation/engine_geolocation_feature.h b/blimp/engine/feature/geolocation/engine_geolocation_feature.h

index d6b1652cb724ad71da52d20ab55199992c476b8d..4219db03ebd54581a03516b8a9dca50b4ac97bec 100644

--- a/blimp/engine/feature/geolocation/engine_geolocation_feature.h

+++ b/blimp/engine/feature/geolocation/engine_geolocation_feature.h

@@ -47,7 +47,6 @@ class EngineGeolocationFeature : public BlimpMessageProcessor,

std::unique_ptr<BlimpMessageProcessor> outgoing_message_processor_;

GeopositionReceivedCallback geoposition_received_callback_;

- scoped_refptr<base::SingleThreadTaskRunner> callback_task_runner_;

base::WeakPtrFactory<EngineGeolocationFeature> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(EngineGeolocationFeature);