Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2639)

Unified Diff: net/socket/websocket_transport_client_socket_pool.h

Issue 2328453002: Refactor WebSocketTransportClientSocketPool's socket handing out code (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/websocket_transport_client_socket_pool.h
diff --git a/net/socket/websocket_transport_client_socket_pool.h b/net/socket/websocket_transport_client_socket_pool.h
index 7b3f21ae8e306ba081ea8e24a2da856603f744cc..786873ec49934fe489b4b0af2028a6f7e73d1db1 100644
--- a/net/socket/websocket_transport_client_socket_pool.h
+++ b/net/socket/websocket_transport_client_socket_pool.h
@@ -209,7 +209,9 @@ class NET_EXPORT_PRIVATE WebSocketTransportClientSocketPool
const CompletionCallback callback;
const BoundNetLog net_log;
};
+
friend class ConnectJobDelegate;
+
typedef std::map<const ClientSocketHandle*, WebSocketTransportConnectJob*>
PendingConnectsMap;
// This is a list so that we can remove requests from the middle, and also
@@ -219,6 +221,10 @@ class NET_EXPORT_PRIVATE WebSocketTransportClientSocketPool
typedef std::map<const ClientSocketHandle*, StalledRequestQueue::iterator>
StalledRequestMap;
+ // Tries to hand out the socket connected by |job|. |result| must be (async)
+ // result of WebSocketTransportConnectJob::Connect(). Returns true iff it has
+ // handed out a socket.
+ bool TryHandOutSocket(int result, WebSocketTransportConnectJob* job);
void OnConnectJobComplete(int result, WebSocketTransportConnectJob* job);
void InvokeUserCallbackLater(ClientSocketHandle* handle,
const CompletionCallback& callback,

Powered by Google App Engine
This is Rietveld 408576698