Issue 232843004: OfflineAudioContext should support up to 32 channels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232843004: OfflineAudioContext should support up to 32 channels. (Closed)

Created:
6 years, 8 months ago by Raymond Toy

Modified:
6 years, 8 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

OfflineAudioContext should support up to 32 channels. Previously, only 10 channels were supported for an OfflineAudioContext. Although the WebAudio specification doesn't explicitly say what the limit is, generally at least 32 channels are required to be supported for all nodes. Added a test that creating an offline context with 32 channels works. BUG=362133 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171480

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -3 lines)			Patch
M	LayoutTests/webaudio/dom-exceptions.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/webaudio/dom-exceptions-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/modules/webaudio/OfflineAudioContext.cpp	View	1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Raymond Toy

On 2014/04/13 08:31:30, Ken Russell wrote: > lgtm Thanks!

6 years, 8 months ago (2014-04-14 16:45:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@chromium.org/232843004/1

6 years, 8 months ago (2014-04-14 16:45:50 UTC) #5

Message was sent while issue was closed.

Change committed as 171480

Expand Messages | Collapse Messages