Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 232843002: Yet more type system tests (Closed)

Created:
6 years, 8 months ago by rossberg
Modified:
6 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Doc #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -103 lines) Patch
M src/types.h View 1 5 chunks +20 lines, -0 lines 1 comment Download
M src/types.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-types.cc View 15 chunks +311 lines, -101 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 8 months ago (2014-04-10 09:52:23 UTC) #1
Benedikt Meurer
lgtm
6 years, 8 months ago (2014-04-10 10:42:11 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/232843002/diff/20001/src/types.h File src/types.h (right): https://codereview.chromium.org/232843002/diff/20001/src/types.h#newcode101 src/types.h:101: // See test/cctest/test-typing.cc for a comprehensive executable specification, Nit: ...
6 years, 8 months ago (2014-04-10 10:54:50 UTC) #3
rossberg
6 years, 8 months ago (2014-04-10 11:49:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698