Fix some leaks associated with memory allocator

Fix some leaks associated with memory allocator

Use CFX_DefStore to only replace CFX_FixedStore, but not
CFX_StaticStore, since CFX_StaticStore has different behaviors.
CFX_StaticStore doesn't require its users to explicitly call free(),
it frees all the allocated memory during destruction. Use
CFX_DefStore to replace CFX_StaticStore would cause leaks.

Also remove two undeclared, but defined, functions.
 
BUG=pdfium:242
Committed: https://pdfium.googlesource.com/pdfium/+/9de00fdc4d4e4dba9e754b337a05809482e4fea2

[Wei Li, 2016-09-12 17:51:00]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-09-12 17:54:15]

Description was changed from

==========
Fix some leaks associated with memory allocator

Use CFX_DefStore to only replace CFX_FixedStore, but not
CFX_StaticStore, since CFX_StaticStore has different behaviors.
CFX_StaticStore doesn't require its users to explicitly call free(),
it frees the all the allocated memory during destruction. Use
CFX_DefStore to replace CFX_StaticStore would cause leaks.

BUG=pdfium:242
==========

to

==========
Fix some leaks associated with memory allocator

Use CFX_DefStore to only replace CFX_FixedStore, but not
CFX_StaticStore, since CFX_StaticStore has different behaviors.
CFX_StaticStore doesn't require its users to explicitly call free(),
it frees the all the allocated memory during destruction. Use
CFX_DefStore to replace CFX_StaticStore would cause leaks.

Also remove two undeclared, but defined, functions.
 
BUG=pdfium:242
==========

[Wei Li, 2016-09-12 17:54:29]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 17:54:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:04:08]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-09-12 18:08:29]

weili@chromium.org changed reviewers:
+ tsepez@chromium.org

[Wei Li, 2016-09-12 18:08:30]

pls review, thanks

[Wei Li, 2016-09-12 18:08:59]

Description was changed from

==========
Fix some leaks associated with memory allocator

Use CFX_DefStore to only replace CFX_FixedStore, but not
CFX_StaticStore, since CFX_StaticStore has different behaviors.
CFX_StaticStore doesn't require its users to explicitly call free(),
it frees the all the allocated memory during destruction. Use
CFX_DefStore to replace CFX_StaticStore would cause leaks.

Also remove two undeclared, but defined, functions.
 
BUG=pdfium:242
==========

to

==========
Fix some leaks associated with memory allocator

Use CFX_DefStore to only replace CFX_FixedStore, but not
CFX_StaticStore, since CFX_StaticStore has different behaviors.
CFX_StaticStore doesn't require its users to explicitly call free(),
it frees all the allocated memory during destruction. Use
CFX_DefStore to replace CFX_StaticStore would cause leaks.

Also remove two undeclared, but defined, functions.
 
BUG=pdfium:242
==========

[Tom Sepez, 2016-09-12 18:18:05]

https://codereview.chromium.org/2328403002/diff/20001/xfa/fgas/crt/fgas_memor...
File xfa/fgas/crt/fgas_memory.cpp (right):

https://codereview.chromium.org/2328403002/diff/20001/xfa/fgas/crt/fgas_memor...
xfa/fgas/crt/fgas_memory.cpp:10: #define MEMORY_TOOL_REPLACES_ALLOCATOR  //
Temporary, for CF testing.
This line is kinda troubling (I probably did it).

[Tom Sepez, 2016-09-12 18:18:22]

LGTM otherwise

[Wei Li, 2016-09-12 21:39:21]

thanks, changed the comment

https://codereview.chromium.org/2328403002/diff/20001/xfa/fgas/crt/fgas_memor...
File xfa/fgas/crt/fgas_memory.cpp (right):

https://codereview.chromium.org/2328403002/diff/20001/xfa/fgas/crt/fgas_memor...
xfa/fgas/crt/fgas_memory.cpp:10: #define MEMORY_TOOL_REPLACES_ALLOCATOR  //
Temporary, for CF testing.
On 2016/09/12 18:18:05, Tom Sepez wrote:
> This line is kinda troubling (I probably did it).

Hope it is better now

[Tom Sepez, 2016-09-12 21:40:04]

lgtm

[Tom Sepez, 2016-09-12 21:40:42]

On 2016/09/12 21:40:04, Tom Sepez wrote:
> lgtm

(What I mean by "troubling" is that the symbol is supposed to be set from the
build environment, but I never got around to setting up all the plumbing)

[Wei Li, 2016-09-12 21:56:18]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:56:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 22:15:22]

Description was changed from

==========
Fix some leaks associated with memory allocator

Use CFX_DefStore to only replace CFX_FixedStore, but not
CFX_StaticStore, since CFX_StaticStore has different behaviors.
CFX_StaticStore doesn't require its users to explicitly call free(),
it frees all the allocated memory during destruction. Use
CFX_DefStore to replace CFX_StaticStore would cause leaks.

Also remove two undeclared, but defined, functions.
 
BUG=pdfium:242
==========

to

==========
Fix some leaks associated with memory allocator

Use CFX_DefStore to only replace CFX_FixedStore, but not
CFX_StaticStore, since CFX_StaticStore has different behaviors.
CFX_StaticStore doesn't require its users to explicitly call free(),
it frees all the allocated memory during destruction. Use
CFX_DefStore to replace CFX_StaticStore would cause leaks.

Also remove two undeclared, but defined, functions.
 
BUG=pdfium:242

Committed:
https://pdfium.googlesource.com/pdfium/+/9de00fdc4d4e4dba9e754b337a05809482e4...
==========

[commit-bot: I haz the power, 2016-09-12 22:15:23]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/9de00fdc4d4e4dba9e754b337a05809482e4...