Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 23283010: Add (mostly Chromium-compatible) V8_OS_* defines to v8.gyp. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add (mostly Chromium-compatible) V8_OS_* defines to v8.gyp. R=jkummerow@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16238

Patch Set 1 #

Patch Set 2 : Properly prefix defines with V8_. #

Total comments: 2

Patch Set 3 : Solaris is not BSD, of course. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M tools/gyp/v8.gyp View 1 2 9 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
This is a first baby-step towards platform cleanup, instead of trying to do everything at ...
7 years, 4 months ago (2013-08-19 09:10:06 UTC) #1
Sven Panne
LGTM, but perhaps Jakob might take a look, too...
7 years, 4 months ago (2013-08-19 14:01:58 UTC) #2
Jakob Kummerow
LGTM. As discussed offline, we might want to move this to build/features.gypi if other targets ...
7 years, 4 months ago (2013-08-20 08:27:26 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/23283010/diff/5001/tools/gyp/v8.gyp#newcode791 tools/gyp/v8.gyp:791: 'V8_OS_BSD=1', On 2013/08/20 08:27:26, Jakob wrote: > really? Nope, ...
7 years, 4 months ago (2013-08-20 08:28:30 UTC) #4
Benedikt Meurer
7 years, 4 months ago (2013-08-20 08:29:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r16238.

Powered by Google App Engine
This is Rietveld 408576698