Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2328293002: [gn] Switch arm cross-compile bots to gn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch arm cross-compile bots to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/9f42d6c2c021a772362f8db26cb705c672a38a7b Cr-Commit-Position: refs/heads/master@{#39367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M infra/mb/mb_config.pyl View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL Comparison: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/3691/steps/compare%20build%20flags%20%28fyi%29/logs/stdio https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/2964/steps/compare%20build%20flags%20%28fyi%29/logs/stdio There are a bunch of differences, but IIUC they shouldn't matter ...
4 years, 3 months ago (2016-09-12 14:23:50 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-12 14:39:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328293002/1
4 years, 3 months ago (2016-09-13 06:35:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 06:36:44 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 06:37:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f42d6c2c021a772362f8db26cb705c672a38a7b
Cr-Commit-Position: refs/heads/master@{#39367}

Powered by Google App Engine
This is Rietveld 408576698