Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2328283002: Revert of [modules] Basic support of exports (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
ulan, adamk, rmcilroy
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [modules] Basic support of exports (patchset #10 id:180001 of https://codereview.chromium.org/2302783002/ ) Reason for revert: Failures related to deopt. Original issue's description: > [modules] Basic support of exports > > This adds partial support of exports to the runtime system and > to the interpreter. It introduces a new HeapObject JSModule that > maps each of the module's export names to a Cell containing the > exported value. > > Several aspects of this implementation are subject to change in > follow-up CLs. > > BUG=v8:1569 > > Committed: https://crrev.com/241a0412eed919395a2e163b30b9b66071ce5c17 > Cr-Commit-Position: refs/heads/master@{#39341} TBR=adamk@chromium.org,rmcilroy@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Committed: https://crrev.com/429ff47e2b50113857ef8d15871f511ee7b910b3 Cr-Commit-Position: refs/heads/master@{#39345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -541 lines) Patch
M src/api.cc View 2 chunks +5 lines, -43 lines 0 comments Download
M src/ast/ast.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ast/modules.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/ast/modules.cc View 1 chunk +18 lines, -19 lines 0 comments Download
M src/ast/scopeinfo.cc View 2 chunks +1 line, -15 lines 0 comments Download
M src/ast/scopes.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/ast/scopes.cc View 4 chunks +5 lines, -15 lines 0 comments Download
M src/ast/variables.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/contexts.cc View 3 chunks +1 line, -10 lines 0 comments Download
M src/debug/debug-scopes.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/factory.h View 3 chunks +1 line, -6 lines 0 comments Download
M src/factory.cc View 3 chunks +6 lines, -20 lines 0 comments Download
M src/heap/heap.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 8 chunks +14 lines, -74 lines 0 comments Download
M src/objects.h View 9 chunks +1 line, -46 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects-inl.h View 5 chunks +0 lines, -18 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +1 line, -12 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -6 lines 0 comments Download
D test/mjsunit/modules-exports1.js View 1 chunk +0 lines, -55 lines 0 comments Download
D test/mjsunit/modules-exports2.js View 1 chunk +0 lines, -31 lines 0 comments Download
D test/mjsunit/modules-exports3.js View 1 chunk +0 lines, -48 lines 0 comments Download
D test/mjsunit/modules-this.js View 1 chunk +0 lines, -7 lines 0 comments Download
M test/test262/test262.status View 3 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
neis
Created Revert of [modules] Basic support of exports
4 years, 3 months ago (2016-09-12 11:33:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328283002/1
4 years, 3 months ago (2016-09-12 11:33:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 11:33:42 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 11:34:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/429ff47e2b50113857ef8d15871f511ee7b910b3
Cr-Commit-Position: refs/heads/master@{#39345}

Powered by Google App Engine
This is Rietveld 408576698