Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2328273004: Fix leaked value object in NamedPropertySetterCallback() (Closed)

Created:
4 years, 3 months ago by Wei Li
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix leaked value object in NamedPropertySetterCallback() When setting a new value for a V8 object property, the passed along pointer of CFXJSE_Value is only used, but needs to be released by the original owner. Use unique_ptr to have the pointer released automatically. BUG=pdfium:242 Committed: https://pdfium.googlesource.com/pdfium/+/1a2419931306bb0905465039dfd773e3bac880d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M fxjs/cfxjse_class.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Wei Li
pls review, thanks
4 years, 3 months ago (2016-09-12 21:40:29 UTC) #6
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-12 22:02:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328273004/1
4 years, 3 months ago (2016-09-12 22:10:30 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 22:10:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/1a2419931306bb0905465039dfd773e3bac8...

Powered by Google App Engine
This is Rietveld 408576698