Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2328263002: Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py (Closed)

Created:
4 years, 3 months ago by tikuta
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py * use chromium.ensure_goma() BUG=621828 Committed: https://chromium.googlesource.com/chromium/tools/build/+/bcdf12617db069e17f963d54e50d1afe44508911

Patch Set 1 #

Messages

Total messages: 17 (8 generated)
tikuta
4 years, 3 months ago (2016-09-12 09:29:37 UTC) #3
shinyak
lgtm
4 years, 3 months ago (2016-09-12 13:17:54 UTC) #4
iannucci
lgtm
4 years, 3 months ago (2016-09-12 23:04:37 UTC) #5
Yoshisato Yanagisawa
lgtm
4 years, 3 months ago (2016-09-13 01:48:09 UTC) #6
ukai
lgtm
4 years, 3 months ago (2016-09-13 02:43:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328263002/1
4 years, 3 months ago (2016-09-13 02:53:33 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/bcdf12617db069e17f963d54e50d1afe44508911
4 years, 3 months ago (2016-09-13 02:59:23 UTC) #15
ukai
On 2016/09/13 02:59:23, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 3 months ago (2016-09-13 03:52:58 UTC) #16
tikuta
4 years, 3 months ago (2016-09-13 03:55:54 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2335093002/ by tikuta@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codese...

args for gn uses old goma_dir..

Powered by Google App Engine
This is Rietveld 408576698