Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2328243002: [LayoutNG] Remove unnecessary #inclusions of LayoutObject and derived class definitions. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Remove unnecessary #inclusions of LayoutObject and derived class definitions. That reduces the number of compilation units that depend on LayoutObject.h by 9 when building content_shell. R=eae@chromium.org Committed: https://crrev.com/11c2346ed2ca5e97f8f019bee856d6ca07a3128a Cr-Commit-Position: refs/heads/master@{#417909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-12 09:06:37 UTC) #1
eae
LGTM
4 years, 3 months ago (2016-09-12 09:09:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328243002/1
4 years, 3 months ago (2016-09-12 09:11:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 10:25:22 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 10:28:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11c2346ed2ca5e97f8f019bee856d6ca07a3128a
Cr-Commit-Position: refs/heads/master@{#417909}

Powered by Google App Engine
This is Rietveld 408576698