Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2807)

Unified Diff: chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc

Issue 2328163002: Revert of Discount for inactivity timeout for recording session length. (https://codereview.chromiu… (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc
diff --git a/chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc b/chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc
index a041fa6dc106771df5be1fd13c44f12770ff7a71..4670e22f60092f77f8783393827f68f09cfc08d8 100644
--- a/chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc
+++ b/chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc
@@ -147,26 +147,3 @@ TEST(DesktopEngagementServiceTest, TestAudioEvent) {
EXPECT_FALSE(instance.is_audio_playing());
histogram_tester.ExpectTotalCount("Session.TotalDuration", 1);
}
-
-TEST(DesktopEngagementServiceTest, TestTimeoutDiscount) {
- base::MessageLoop loop(base::MessageLoop::TYPE_DEFAULT);
- base::HistogramTester histogram_tester;
-
- MockDesktopEngagementService instance;
- instance.SetInactivityTimeoutForTesting(2);
-
- instance.OnVisibilityChanged(true);
- instance.OnUserEvent();
- histogram_tester.ExpectTotalCount("Session.TotalDuration", 0);
-
- // Wait until the session expires.
- while (!instance.is_timeout()) {
- base::RunLoop().RunUntilIdle();
- }
-
- histogram_tester.ExpectTotalCount("Session.TotalDuration", 1);
-
- // The recorded value should be in the 0 bucket even though inactivity timeout
- // is 2 seconds.
- histogram_tester.ExpectUniqueSample("Session.TotalDuration", 0, 1);
-}
« no previous file with comments | « chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698