Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 23281003: Add libraries to fix Ubuntu13 Clang build (Closed)

Created:
7 years, 4 months ago by borenet
Modified:
7 years, 4 months ago
Reviewers:
bungeman-skia, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M gyp/common_conditions.gypi View 1 2 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
borenet
7 years, 4 months ago (2013-08-19 17:32:57 UTC) #1
djsollen
https://codereview.chromium.org/23281003/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/23281003/diff/1/gyp/common_conditions.gypi#newcode250 gyp/common_conditions.gypi:250: }, { can you comment that this is skia_os ...
7 years, 4 months ago (2013-08-19 18:02:09 UTC) #2
borenet
Patch set 2. https://codereview.chromium.org/23281003/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/23281003/diff/1/gyp/common_conditions.gypi#newcode250 gyp/common_conditions.gypi:250: }, { On 2013/08/19 18:02:10, djsollen ...
7 years, 4 months ago (2013-08-19 18:05:27 UTC) #3
bungeman-skia
https://codereview.chromium.org/23281003/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/23281003/diff/1/gyp/common_conditions.gypi#newcode258 gyp/common_conditions.gypi:258: [ 'skia_os == "chromeos"', { Since this block seems ...
7 years, 4 months ago (2013-08-19 18:05:32 UTC) #4
borenet
Patch set 3. https://codereview.chromium.org/23281003/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/23281003/diff/1/gyp/common_conditions.gypi#newcode258 gyp/common_conditions.gypi:258: [ 'skia_os == "chromeos"', { On ...
7 years, 4 months ago (2013-08-19 18:08:01 UTC) #5
bungeman-skia
lgtm
7 years, 4 months ago (2013-08-19 18:08:53 UTC) #6
djsollen
lgtm
7 years, 4 months ago (2013-08-19 18:24:43 UTC) #7
borenet
7 years, 4 months ago (2013-08-19 18:26:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r10796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698