Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2328043002: Move exception support to its own library (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -191 lines) Patch
M pkg/analysis_server/benchmark/integration/instrumentation_input_converter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/benchmark/integration/log_file_input_converter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_logger.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/tree_writer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer/lib/exception/exception.dart View 1 chunk +99 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 4 chunks +43 lines, -46 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_engine.dart View 1 chunk +2 lines, -96 lines 0 comments Download
M pkg/analyzer/lib/src/generated/package.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/yaml.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/model.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/model_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/options_work_manager_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/test_support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-10 15:23:01 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-10 16:55:35 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-10 18:04:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6c448b6938f7796de9d8a52ee8cd83453ce98221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698