Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/bindings/modules/BUILD.gn

Issue 2328033002: Revert of Remove more blink modules gypi code. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/scripts.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/modules/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/modules/BUILD.gn b/third_party/WebKit/Source/bindings/modules/BUILD.gn
index 2da19b9833309c037ed923cf75123ef3c16a62db..4c12e2a15e02dd565b91895c02a49bd68b91a72e 100644
--- a/third_party/WebKit/Source/bindings/modules/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/modules/BUILD.gn
@@ -6,16 +6,19 @@
import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
import("//third_party/WebKit/Source/build/scripts/scripts.gni")
+visibility = [ "//third_party/WebKit/*" ]
+
+# GYP version: Source/bindings/modules/generated.gyp:bindings_modules_generated
group("bindings_modules_generated") {
- visibility = [ "//third_party/WebKit/*" ]
public_deps = [
- ":event_modules",
- ":event_modules_names",
- ":event_target_modules_names",
+ ":bindings_modules_generated_event_modules_factory",
+ ":bindings_modules_generated_event_modules_names",
+ ":bindings_modules_generated_event_target_modules_names",
":modules_bindings_generated_event_interfaces",
]
}
+# GYP version: event_interfaces action in bindings_modules_generated
generate_event_interfaces("modules_bindings_generated_event_interfaces") {
sources = [
"//third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.idl",
@@ -62,28 +65,32 @@
suffix = "Modules"
}
-make_event_factory("event_modules") {
- visibility = [ ":*" ]
+# GYP version: EventModulesFactory action in bindings_modules_generated
+make_event_factory("bindings_modules_generated_event_modules_factory") {
in_files = [ "$root_gen_dir/blink/EventModulesInterfaces.in" ]
outputs = [
"$blink_modules_output_dir/EventModules.cpp",
"$blink_modules_output_dir/EventModulesHeaders.h",
]
- deps = make_core_generated_deps + [ "//third_party/WebKit/Source/bindings/modules:modules_bindings_generated_event_interfaces" ]
+ deps = [
+ "//third_party/WebKit/Source/bindings/modules:modules_bindings_generated_event_interfaces",
+ ]
}
-make_names("event_modules_names") {
- visibility = [ ":*" ]
+# GYP version: EventModulesNames action in bindings_modules_generated
+make_names("bindings_modules_generated_event_modules_names") {
in_files = [ "$root_gen_dir/blink/EventModulesInterfaces.in" ]
outputs = [
"$blink_modules_output_dir/EventModulesNames.cpp",
"$blink_modules_output_dir/EventModulesNames.h",
]
- deps = make_core_generated_deps + [ "//third_party/WebKit/Source/bindings/modules:modules_bindings_generated_event_interfaces" ]
+ deps = [
+ "//third_party/WebKit/Source/bindings/modules:modules_bindings_generated_event_interfaces",
+ ]
}
-make_names("event_target_modules_names") {
- visibility = [ ":*" ]
+# GYP version: EventTargetModulesNames action in bindings_modules_generated
+make_names("bindings_modules_generated_event_target_modules_names") {
in_files = [ "../../modules/EventTargetModulesFactory.in" ]
outputs = [
"$blink_modules_output_dir/EventTargetModulesNames.cpp",
@@ -114,6 +121,7 @@
]
}
+# GYP version: Source/bindings/modules/generated.gyp:interfaces_info
action("interfaces_info") {
script = "$bindings_scripts_dir/compute_interfaces_info_overall.py"
@@ -143,6 +151,7 @@
]
}
+# GYP version: Source/bindings/modules/generated.gyp:modules_global_objects
compute_global_objects("modules_global_objects") {
sources = modules_idl_files
sources_generated = [ "$bindings_core_output_dir/GlobalObjectsCore.pickle" ]
@@ -152,6 +161,7 @@
]
}
+# GYP version: Source/bindings/modules/generated.gyp:modules_core_global_constructors_idls
generate_global_constructors("modules_core_global_constructors_idls") {
sources = core_idl_files + core_idl_with_modules_dependency_files
global_objects_file =
@@ -164,6 +174,7 @@
]
}
+# GYP version: Source/bindings/modules/generated.gyp:modules_global_constructors_idls
generate_global_constructors("modules_global_constructors_idls") {
sources = modules_idl_files
global_objects_file =
@@ -175,28 +186,3 @@
":modules_global_objects",
]
}
-
-# Compile the sources produced above. This will get linked into "modules".
-source_set("generated") {
- visibility = [ "//third_party/WebKit/Source/modules" ]
-
- sources = get_target_outputs(":event_modules") +
- get_target_outputs(":event_modules_names") +
- get_target_outputs(":event_target_modules_names")
-
- configs += [
- "//third_party/WebKit/Source:config",
- "//third_party/WebKit/Source/modules:modules_implementation",
- "//third_party/WebKit/Source:non_test_config",
- "//third_party/WebKit/Source:inside_blink",
- ]
-
- deps = [
- ":event_modules",
- ":event_modules_names",
- ":event_target_modules_names",
- "//third_party/WebKit/Source/core",
- "//third_party/WebKit/Source/wtf",
- "//v8",
- ]
-}
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/scripts.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698